Comments (7)
From reading the Github API documentation, it appears that unauthenticated requests from the same IP are limited to 60 per hour.
For unauthenticated requests, the rate limit allows for up to 60 requests per hour.
Unauthenticated requests are associated with the originating IP address, and not the person making requests.
If we implement this feature without the flag, users may end up consuming a number of API requests on github every time they run tcping.
Is there any good way to do this?
from tcping.
This is my first time dealing with this type of problem, but I would like to give it a try.
The following is the process I'm considering
- Get release version with go-github package.
- Compare with const version.
- If latest version is exist, print message to prompt for version up.
What do you think?
P.S.
I become able to use slack!
If you have no problem, please invite me.
from tcping.
This is my first time dealing with this type of problem, but I would like to give it a try. The following is the process I'm considering
- Get release version with go-github package.
- Compare with const version.
- If latest version is exist, print message to prompt for version up.
What do you think?
P.S. I become able to use slack! If you have no problem, please invite me.
Hi,
Your thought process looks fine to me as well.
I am not really familiar with go-github
package but it is fine for me.
I would like to keep our program clean and also as simple as possible. If you notice, I did refactor a lot of things over the weekend as well.
I also contacted you through the email you provided (and removed the email from your comment for privacy reasons).
from tcping.
From reading the Github API documentation, it appears that unauthenticated requests from the same IP are limited to 60 per hour.
For unauthenticated requests, the rate limit allows for up to 60 requests per hour.
Unauthenticated requests are associated with the originating IP address, and not the person making requests.If we implement this feature without the flag, users may end up consuming a number of API requests on github every time they run tcping.
Is there any good way to do this?
That is a very valid concern. Let's not automatically do it by default.
Better to only do it when they actually check for an update.
from tcping.
Based on the discussion here, this issue can be ruled out in favor of #15
from tcping.
Hi.
Your thought process looks fine to me as well.
Thank you for your opinion!
That is a very valid concern. Let's not automatically do it by default.
I see.
I'll make sure it's finally implemented that way.
Better to only do it when they actually check for an update
Yes, I think too. But, I don't have any ideas at the moment.
First, when I implement the update message is displayed without flag, I will put out a PR.
from tcping.
Hi.
Your thought process looks fine to me as well.
Thank you for your opinion!
That is a very valid concern. Let's not automatically do it by default.
I see. I'll make sure it's finally implemented that way.
Better to only do it when they actually check for an update
Yes, I think too. But, I don't have any ideas at the moment.
First, when I implement the update message is displayed without flag, I will put out a PR.
perfect!
from tcping.
Related Issues (20)
- README Translation - Chinese
- add TTL in output please HOT 3
- Please add "count" and "interval" option HOT 3
- Add tcping to winget
- output interface HOT 13
- v2.0.0 is not listed on Go module proxy due to missing /v2 suffix in the "module" path HOT 8
- fix database user input flag HOT 8
- Database closure before the appropriate time. HOT 2
- Include db.go in the Makefile HOT 10
- refactor the processUserInput function HOT 8
- reduce RTT floating point precision when storing them into the database HOT 3
- Add Prometheus exporter HOT 12
- Assess replacing current sqlite package HOT 6
- re-add the static Linux binary
- wrong downtime calculation when timeout is set to under a second
- Significant size increase HOT 4
- break build section of Makefile into smaller chunks
- add -h flag to show help HOT 1
- add time in output line please HOT 7
- fix CI warnings HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from tcping.