Code Monkey home page Code Monkey logo

Comments (2)

guruofquality avatar guruofquality commented on July 28, 2024

I am very new to SoapySDR (and SDR in general, for that matter). I would be happy to send in a pull request, but first I'd appreciate some feedback from the maintainers regarding the preferred approach.

Sounds great, thats exactly what overriding setGain is for. A PR would be very helpful, and gives us something specific to discuss.

from soapysdrplay2.

dlaw avatar dlaw commented on July 28, 2024

@guruofquality Thanks for the response! I've opened #61 with the larger set of changes to bring SoapySDRPlay in line with the SoapySDR gain abstraction. I think this is the best long-term solution.

A simpler change would be to keep the non-standard RFGR and IFGR, and override setGain to ensure that RFGR is never changed. I think this solution is more confusing in the long term, and it's not consistent with the behavior of other SoapySDR hardware interfaces.
pothosware/SoapySDRPlay3@master...dlaw:master

The argument I see for the simpler solution would be concern over breaking existing configurations. But if you agree, I'd prefer to move ahead with the changes as sketched out in #61.

from soapysdrplay2.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.