MySQLi: Reuse existing connection about postfixadmin HOT 6 CLOSED

I merged #41 (thanks!) and also reverted most of c253ef7 - there's no need for additional caching in escape_string().

from postfixadmin.

Are you sure this still happens with the latest code we have on github?

Commit c253ef7 (done about a month ago) claims to have this fixed ;-)

That said - your fix looks better, so I seriously think about accepting your patch and reverting c253ef7 ;-)

from postfixadmin.

My fix was only to allow a connection to be passed into the escape_string() function; this on the other hand short cuts the db_connect() function if a connection has been opened before. So they're slightly different.

There is already a static $link in db_query() ...

https://github.com/postfixadmin/postfixadmin/blob/master/functions.inc.php#L1419

from postfixadmin.

Are you sure this still happens with the latest code we have on github?

Nope, it's the Debian package from Stretch. Sorry, I didn't see the issue/commit. But I think it's a little bit different.

from postfixadmin.

There is already a static $link in db_query() ...

But it's useless when calling db_connect() from other functions like escape_string().

mysqli_connect() returns always a new connection:

(PHP 5, PHP 7)
mysqli::__construct -- mysqli_connect — Open a new connection to the MySQL server

from postfixadmin.

Agreed, db_connect() is irrelevant for escape_string() - and caching the connection directly in db_connect() is probably the best thing we can do.

I still think that this fix is better than c253ef7 ;-)

from postfixadmin.