post-kerbin-mining-corporation / cryotanks Goto Github PK

When changing the tank type of a tank in symmetry, all of the other tanks connected in symmetry won't have the original resource removed. The duplicated resource disappears when using certain buttons in the editor (including launch).

Tested on version 1.11.1 with no mods other then CryoTanks and dependencies, also occurs in 1.10.1 and presumably 1.11.2.

Screenshots:
https://imgur.com/a/pOVwANL

I have been getting this for a while and i noticed this was a previous problem. I get massive spam of this error. Can a game get unstabled over time? Would a reinstall help?

NullReferenceException: Object reference not set to an instance of an object
SimpleBoiloff.ModuleCryoTank.Update () (at <249ca1d9eb3c4f67a8d3a27f87ab9164>:0)
UnityEngine.DebugLogHandler:LogException(Exception, Object)
ModuleManager.UnityLogHandle.InterceptLogHandler:LogException(Exception, Object)
UnityEngine.Debug:CallOverridenDebugHandler(Exception, Object)

When i go to use liquid fuel tanks (like in the beginning of the carreer) it doesn't show an option to use liquid fuel. just the boil off rates and capacities for liquid hydrogen and methane.

Requesting a patch for COT-125 MiniISRU that provides H20 conversion to LH2/Ox functionality, similar to current CryoTanks patch for COT-250.

Yesterday I saw the following behaviour: cryo consumption was 2 EC/s, solar generator produced 1.5 EC/s. EC Level dropped to zero, I lost vessel control, so no chance to disable cooling and regain control.

2 possible solutions:

• always make cooling deactivateable regardless of vessel control
• only use EC up to a given threshold, like ion engines do now

I can PR the second suggestion, don't know if the first one is possible.

I see you've updated the tank types and tank switcher patches to have your ZBO tanks weight the same as lifter tanks (0.25 kg per 10 units LH2), but the dry masses of the tanks themselves are still the same values -- so (for example) the HI-M-10 has 3200 units of volume and should weigh 0.8 tons in its LH2 variant (which it does in the B9PartSwitcher module), but its "mass" variable is still 1 ton, so it weighs 0.2 tons too much in all variants. Likewise for your other LH2 tanks.

I'd make a pull request with the fixes, but I see you haven't committed the rebalanced tank type and tank switcher patches to this repo yet, so I don't want to risk stepping on any files.

output_log.txt

The cost is calculated from tank current capacity on part load when it should be calculated from max capacity.

Ability to mark tanks so that boil off mitigation is not possible.

Simply, add !MODULE[WBIResourceSwitcher to the general patch to stop other mods' fuel switchers being overwritten.

Due to BoiloffOccurring never being unset once it's set. Easy fix when I have time.

Hello! I'm loving the mod, but I've encountered an issue recently. I'm not sure whether it's from the cryo tanks themselves, or something else. I've uploaded my log file, and something from the exception detection mod. Is there anything else you would need from me?

edu.log
Player.log

I observe some messed up normals (I guess, it effects highlight and lighting) on just this one tank with only the isohedral modes. https://imgur.com/a/IxY9Sob . I'm hoping it's just an easy mistake on the asset, but if it's some weird mod interaction I can upload more logs. Thanks!

During a session, I noticed that tanks would boil off at over 1000x warp. At 1000x , they would work just fine. Any faster, however, and the tanks would begin to boil off. I switched on infinite electricity, and the game demonstrated the same problem.
KSP.log attached
KSP.log
:

Rework all hydrogen tanks to have an alternate white/faceted texture

• hydrogen-10-1
• hydrogen-375-1
• hydrogen-375-2
• hydrogen-375-3
• hydrogen-25-1
• hydrogen-25-2
• hydrogen-25-3
• hydrogen-125-1
• hydrogen-125-2
• hydrogen-radial-125-1
• hydrogen-radial-25-1
• hydrogen-radial-375-1

Is there any config to make this mod compatible with RO?

Specifically, the 3.75 m tanks have gaps (as shown) for compact and bare variants. The 5 m tank does not have a similar gap for compact variant (it lines up just fine), but it does for the bare variant. It looks like a model issue where the inner rings aren't consistently vertically aligned with the outer rings.

Fix this as per http://forum.kerbalspaceprogram.com/index.php?/topic/106089-121-cryogenic-engines-high-isp-chemical-rockets-nov-18-various-fixes/&do=findComment&comment=2862803

Fuel Tanks Plus has nuke specific tanks, I think this makes them great candidates to have compatibility with cryo tanks + Kerbal Atomics.

ksp version: 1.8.1
CryoTanks version: 1.4

Since the CrytoTanksFuelSwitcher.cfg entires have the

!MODULE[ModuleEnginesFX],!MODULE[ModuleEngines]

conditions, this fuel tank doesn't have fuel switcher module(due to the SRBs).
I got a workaround by declaring these switchers for this part as well. But I wonder if there is a better solution:

CryoTanksFuelTankSwitcherExceptions.txt

Mods used on the craft:
HeatControl
Sterling Systems Core, Engines and Tankage
NF Electrical
RealChutes
MkIV Expansion

and a zip file of everything you need including a video:
https://www.mediafire.com/file/5d70bqha6r32krj/problem_stuff.zip/file
(couldnt upload directly because github said it was too big)

If multiple resources in a tank are cryo fuels the EC cost for each will count the entire contents of the tank. For example if adding fusion fuels to regular zbo tanks, the combined deuterium/helium3 switch costs twice as much to cool than the single ones or the hydrogen.

Far future goes around this by setting a global cost but this doesnt work if fuels have different cooling costs. You cant do a LOx/LH2 config for example, which seems quite a breaking bug.

I havent tested the actual boiloff, just the EC cost

Cryo tanks count as fully cooled when any Ec is present, instead of the minimum required Ec

Hello, first of all thanks for all the wonderful modding work !

I just have this issue where the fuel switching option isn't showing on any tank, and after a few minutes of head scratching I have no idea what might cause this. I'm quite new to KSP modding and Github so apologies if this has already been addressed.

Here are the mods I have currently installed, and here's the KSP.log file, please let me know if you need anything else.

Have a nice day,
Artemis

In career mode, the money of100% recovery is inflated for LH2/OX tank and heavily discounted for LCH4/OX tank. E.g., the basic 1.25m tank FL-T1100 costs $104 when empty, when loaded with LH2/OX, I can recover $126 out of it, but when loaded with Methane/LOX, I can only recover $54.

Localize up the plugin

There are ERRors in the KSP Log with CryoTanks, because the *.mu files are mentioning *.tga files that do not exist.

Example:
KSP.log entry:
[LOG 20:14:26.336] Load(Model): CryoTanks/Parts/HydrogenTanks/hydrogen-10/hydrogen-10-1
[ERR 20:14:26.356] Texture 'CryoTanks/Parts/HydrogenTanks/hydrogen-10/hydrogen-10-n' not found!

hydrogen-10-1.mu file asks for hydrogen-10-n.tga (last line if opened with NP++, after _BurnColor)

I tested in a fresh 1.10 install with just the near future mods. Teleporting a ship into orbit and timewarping 200 days in the space center. After returning to the ship no boiloff has occured. Timewarping while focused on the ship works normally. I tested in 1.7 and 1.9 and it happens there too.

I know ckan isnt supported but this isnt a ckan issue. I installed some other near future mods through ckan, cryo tanks popped up as recommended and I added it as well, its metadata description (I assume set through your git/version files, if not Ill take this to ckan if they fill it out) states "A set of fuel tanks containing liquid hydrogen, with active cryo-cooling." Making it seem like it was additional hydrogen tanks which is always a win for me. The only issue I had is the MM patch included overwrites all tanks that can contain lf/ox with your versions. This superseded IFS and other mods patching CRP fuels in on pretty much every tank in the game (including some other mods tanks designed to work with CRP ). The specific patch currently included using B9 partswitch to patch into every lf/o tank does make sense in a stock/near future only install, but not when other mods are included that use other fuels. Maybe make it an optional patch for all lf/o tanks and include only patch near future tanks that can contain cryo fuels(with b9 being used as the texture switcher it makes sense) as standard?

With the newest release locking the fuel flow in a tank stops it from boiling off. This doesnt happen in 1.6.1

It seems that having both this and SimpleFuelSwitch by @KSPSnark installed results in the option to change tank types for Stock being hidden/disabled and NF tanks not having the cryo fuels as options. I only noticed because I initially didn't have this mod and used the other mod to hold only liquid fuel for nuclear engines.

I don't think anything needs to be fixed as this mod makes the fuel switcher redundant anyways, but it could be helpful for others to add conflict between the two to the CKAN metadata.

New fuel tanks in all sizes and stylings, including frame-less radial variants.

• XL Size (double largest 3.75m tank)
  • Foil
    • Inline
    • Frame-less
  • Iso
    • Inline
    • Frame-less
• Full Size (largest 3.75m tank)
  • Foil
    • Inline
    • Frame-less
  • Iso
    • Inline
    • Frame-less
• Half Size
  • Foil
    • Inline
    • Frame-less
  • Iso
    • Inline
    • Frame-less
• Quarter Size
  • Foil
    • Inline
    • Frame-less
  • Iso
    • Inline
    • Frame-less

HB-8 tank attachment structure is not playing nice with cylindrical hosts. Some top-down mirror-symmetrical structure would fit nicer than radially symmetrical frame.

CryoTanks don't correctly apply to Restock tanks. It seems to be a load order issue for the patch: :FOR[zzz_CryoTanks] loads before the :AFTER[zzz_Kerbalism] tag that Restock targets for some of the problematic tanks. However even changing to :LAST[zzz_CryoTanks] doesn't fix the patch (in fact, for some reason it creates double ModularFuelTank modules), so I'm certain that there's more to it than that.

Tanks that I know have the issue:

• The FL-06-018 expansion line (Oscar-A through Oscar-D)
• NOT the FL-06-018 Oscar-B itself
• FS-06-009
• FS-12-050
• FS-18-220

Needs some work, but create some orbital tanks that are flatter than the current techniques allow.

Potential scope, likely to change:

• 5m Half Size
• 5m Quarter Size
• 5m Eighth Size
• 3.75m Quarter Size
• 2.5m Qaurter Size
• 1.25m Quarter Size

From @Stratickus

Feature Request: Ability to Enable/Disable Cooling for Cryo tanks in VAB/Editor.

Would allow for minimizing EC drain for 1st stage tanks where boiloff is usually not a concern. This would be beneficial as it would persist across saved craft files. As it stands it must be done prior to launch or inflight.

This may apply not only to cryo stuff, but half-spherical tanks could serve as handy additional storage and stylish endcaps.

I've managed to narrow this error down to Cryo tanks, but I can't for sure pin down which mod is also causing the problem. Though my guess is that it might be SIMPLEX resources, I'm not sure.

modlist.txt
KSP.log

log file and modlist attached

[EXC 08:47:23.724] InvalidOperationException: Operation is not valid due to the current state of the object
	System.Linq.Enumerable.Single[UrlConfig] (IEnumerable`1 source, System.Func`2 predicate, Fallback fallback)
	System.Linq.Enumerable.Single[UrlConfig] (IEnumerable`1 source, System.Func`2 predicate)
	SimpleBoiloff.ModuleCryoTank.Start ()
[EXC 08:47:23.732] NullReferenceException: Object reference not set to an instance of an object
	SimpleBoiloff.ModuleCryoTank.Update ()
[EXC 08:47:23.738] NullReferenceException: Object reference not set to an instance of an object
	SimpleBoiloff.ModuleCryoTank.Update ()

Followed by the last error a few thousand times.
KSP - Cryotanks.zip

NREs are spammed to the log when a ZBO tank is toggled to have no boiloff-managed resources (eg, Oxidizer only) in the VAB.

• Remove the CryoMonitor component and replace with a hardlink to the Power Monitor component from the FFT project.
• Refactor the Boiloff module to use the PowerMonitor component

I am not getting any options to turn stock tanks into methane tanks. Hydrogen works just fine but not methane. KSP ver 1.10.1 with Near Future, REstock, Kerbalism and Kiwi Tech Tree among other mods installed that shouldn't conflict.

Rework all inline fuel tanks to have an alternate, slightly shorter frame-less model.

• hydrogen-10-1
• hydrogen-375-1
• hydrogen-375-2
• hydrogen-375-3
• hydrogen-25-1
• hydrogen-25-2
• hydrogen-25-3
• hydrogen-125-1
• hydrogen-125-2

The MM patches currently do not patch fuel tanks parts that already define a switcher, such as IFS, firespitter, or WBIConvertableStorage.

This exclusion should also include parts with Module WBIOmniStorage, as these work like WBIConvertibleStorage (just a newer type of storage that Angel-125 is using nowadays).

Example where the CryoTanks patch conflicts with a part that has WBIOmniStorage is in Angel-125's mod MOLE, part wbiShieldedTank.

Looking at the LMOx tank mass:
https://github.com/ChrisAdderley/CryoTanks/blob/63468f03eda5e23c6368ef1d57f899fcf72bb927/GameData/CryoTanks/Patches/CryoTanksFuelTankTypes.cfg#L112
This tank mass is 1/11th the fuel mass (increased from ~1/14th by commit b451ae9). If that's intended to represent advanced super-lightweight tank technology, that's great, but the pure LM tank has the usual 1/8th mass figure. To get the LMOx tank to that balance point, the mass should be 0.000490377. (Unless I'm using the wrong mass figures or something -- I'm using 0.005 t/unit for Ox, 0.00042561 t/unit for LM).

It was recently brought to my attention that the CryoTanksFuelTankSwitcher.cfg is causing a negative dry mass in a part from MKS when in Liquid Hydrogen configuration. This causes all sorts of problems and explosions.
Some info on the part in question: in stock, it has a dry mass of .25 tons and holds 315 units of Liquid Fuel and 385 units of Oxidizer

also on the Cryogenic Engines forum page for moar visibility

Finish localizing all the config files in preparation for 1.3