omxplayer --win not work about omxplayer HOT 11 CLOSED

--win bug first appears in omxplayer_0.3.0git201308146e81c95_armhf.deb (http://omxplayer.sconde.net/ builds).

from omxplayer.

I can't confirm the bug atm (I'm far away from my raspberry) but if the first non-working version is the one @ktws says then the problem should be between efd1049 and 6e81c95

from omxplayer.

I can confirm that this is broken in c99bc80.

from omxplayer.

Issue is closed in both huceke/omxplayer and popcornmix/omxplayer, but I have not managed to see any feedback?

from omxplayer.

It's not closed here, this issue is still open.

from omxplayer.

I think the problem is this code (comments are my corrections). It works after this fix

void COMXVideo::SetVideoRect(const CRect& SrcRect, const CRect& DestRect)
{
if(!m_is_open)
return;

//if ( !m_settings_changed || !((DestRect.x2 > DestRect.x1 && DestRect.y2 > DestRect.y1) || m_pixel_aspect != 0.0f) )
if ( !((DestRect.x2 > DestRect.x1) && (DestRect.y2 > DestRect.y1)) && (m_pixel_aspect == 0.0f) ){
return;
}

OMX_ERRORTYPE omx_err;
OMX_CONFIG_DISPLAYREGIONTYPE configDisplay;
OMX_INIT_STRUCTURE(configDisplay);
configDisplay.nPortIndex = m_omx_render.GetInputPort();

// configured dest_rect takes precedence
//if (DestRect.x2 > DestRect.x1 && DestRect.y2 > DestRect.y1)
if ((DestRect.x2 > DestRect.x1) && (DestRect.y2 > DestRect.y1))

from omxplayer.

I've pushed a fix. @jmeiners can you confirm it works okay?

from omxplayer.

I tested the latest version but the problem is still. I run this command
omxplayer --win "40 20 338 277" "rtsp://admin:[email protected]:554/cam/realmonitor?channel=1&subtype=1"
but it view fullscreen

from omxplayer.

@popcornmix Yes, it works for me.

from omxplayer.

@popcornmix, if it is fixed this issue should be closed...

from omxplayer.

Thanks
for your attention!!!!

----- Messaggio originale -----

Da: "Rasmus Christiansen" [email protected]
A: "popcornmix/omxplayer" [email protected]
Cc: "PaoloBasso" [email protected]
Inviato: Martedì, 9 giugno 2015 9:24:59
Oggetto: Re: [omxplayer] omxplayer --win not work (#41)

@popcornmix , if it is fixed this issue should be closed...
—
Reply to this email directly or view it on GitHub .

from omxplayer.