Code Monkey home page Code Monkey logo

Comments (4)

tinogo avatar tinogo commented on June 2, 2024 3

We've came up with a solution. We created a new class decorator, which overrides the default @Injectable() decorator.

import { Injectable, InjectableOptions, Scope } from '@nestjs/common';
import { basename } from 'path';

export function InjectableCliAware(options?: InjectableOptions): ClassDecorator {
  if (basename(process.argv[1]) === 'console.js' && options?.scope === Scope.REQUEST) {
    options.scope = Scope.DEFAULT;
  }
  return Injectable(options);
}

So I think, we can close this issue?! :)

from nestjs-console.

Rmannn avatar Rmannn commented on June 2, 2024

You can't inject scoped service in a non scoped service.
@Injectable({ scope: Scope.REQUEST }) means your service only exists when a request is created.

Scoped thing does not make sense in a headless app.

See https://docs.nestjs.com/fundamentals/injection-scopes#scope-hierarchy

Scope bubbles up the injection chain. A controller that depends on a request-scoped provider will, itself, be request-scoped.

from nestjs-console.

tinogo avatar tinogo commented on June 2, 2024

Hello @Rmannn,

thank you for your quick reply. :)

Sooo, the only solution for us would be to duplicate the request scoped service to be not request scoped (we can not simply drop the request scoping, as this service holds a request based cache (for the GraphQL- and REST-contexts).

As already said, we are aware that this kind of thing doesn't make much sense for a headless app, but we wanted to reuse the service to reduce code duplication.

Do you have another solution in mind?

from nestjs-console.

Rmannn avatar Rmannn commented on June 2, 2024

Nice solution!

from nestjs-console.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.