Code Monkey home page Code Monkey logo

Comments (13)

pooler avatar pooler commented on June 20, 2024

Thank you for reporting this.
Looks like I'll have to buy me a Trezor, so that I can debug this :)

from electrum-ltc.

wozz avatar wozz commented on June 20, 2024

I have the same error. I can't see why anything should be different than Bitcoin except the CoinType, which looks correct.

@MarvinOl have you tried sending any LTC yet? I haven't put anything in my trezor wallet yet so cannot confirm if that works.

from electrum-ltc.

MarvinOl avatar MarvinOl commented on June 20, 2024

@wozz nope - I have not read the full protocol documentation but as far as I understand signing messages is basically the same operation as sending coins (sending coins is just a specially formatted signed "text message" - correct me if I got this wrong). I have not yet used real LTC with my Trezor as message signing does not work.

from electrum-ltc.

wozz avatar wozz commented on June 20, 2024

I was able to confirm that bitcoin testnet message signing (and transaction sending) is working on trezor, which is also treated as a separate coin type. The interface to the trezor is two separate commands for message signing and transaction signing, so it's possible tx signing works without message signing working.

from electrum-ltc.

wozz avatar wozz commented on June 20, 2024

Ok, just confirmed sending transactions is working for me. So only message signing is broken to my knowledge.

from electrum-ltc.

MarvinOl avatar MarvinOl commented on June 20, 2024

Thanks for the Trezor support again! I bit the bullet and tested with real LTC - no problems, works as expected. So there are clearly 2 different operations with signing messages and signing transactions - and signing transactions works with no problems.

from electrum-ltc.

wozz avatar wozz commented on June 20, 2024

I've opened an issue in the Trezor repository: trezor/trezor-mcu#3

from electrum-ltc.

prusnak avatar prusnak commented on June 20, 2024

I recommend changing the magic to "Bitcoin Signed Message" here:
https://github.com/pooler/electrum-ltc/blob/v1.9.8.4/lib/bitcoin.py#L351
This is a very poor decision to break things appart for no obvious reason.

from electrum-ltc.

pooler avatar pooler commented on June 20, 2024

@prusnak: Litecoin Core has been using the magic string "Litecoin Signed Message" since 2011. What you are proposing would break compatibility with all other Litecoin clients, which is highly undesirable.

from electrum-ltc.

prusnak avatar prusnak commented on June 20, 2024

That is indeed very unfortunate ... I'll reopen the trezor-mcu issue.

from electrum-ltc.

prusnak avatar prusnak commented on June 20, 2024

Fixed in TREZOR firmware 1.3.6

from electrum-ltc.

pooler avatar pooler commented on June 20, 2024

@prusnak Thank you!

from electrum-ltc.

prusnak avatar prusnak commented on June 20, 2024

See #34 though.

from electrum-ltc.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.