Comments (4)
No problems !
I won't have much time until Saturday to do it, but I'll try to add it this week-end.
I want to write better tests before adding any more features though, right now the tests don't cover everything properly and I'm always afraid to miss things.
from cargo-intraconv.
This should work well now and this is tested so (hopefully) it won't break any time soon
from cargo-intraconv.
I'm not yet ready to do this (still writing more tests in the better-tests
branch) but I'm thinking about it. Here is what I have:
- Always show the item type (if any) at the end of the diff line (
384: "old line" (item disambiguation: 'type@')
) - A
--disambiguate
(short-d
) option that would apply thetype@
automatically (for a first implementation, all of them, on all the given files) - Always add the
()
and!
disambiguation since they make the link very clear and do not clutter as much as 'type@' or 'primitve@' do.
What do you think about it ?
from cargo-intraconv.
I like always applying ()
and !
very much, as well as making type@
opt-in. I don't have strong opinions on displaying the disambiguator when the link is converted; I mostly skip over that text anyway 🙃
from cargo-intraconv.
Related Issues (20)
- Run on all crates in the workspace HOT 3
- Don't remove links that are the same except for a disambiguator HOT 1
- Replace `docs.rs/crate` with `crate`
- Some links are not caught HOT 5
- Convert doc.rust-lang.org to intra-doc links HOT 5
- Redundant links are not removed if they were originally HTTP links HOT 1
- [stretch] convert <a href=""> to intra-doc links HOT 3
- -a removes all whitespace
- docs.rs/crate/x is treated as if crate/ is a crate HOT 6
- Properly detect blocks HOT 1
- Wrongly detect short form of a crate for docs.rs
- Add a way to ignore links HOT 10
- If a favored url is converted to the current crate, use `crate::` instead HOT 4
- Take backticks into account when removing links that are the same HOT 3
- `index.html` should link to `self`, not the current page
- Intraconv shouldn't convert links to primitives HOT 1
- Read `intraconv.toml` by default
- Ignore file compares the whole line, not the link HOT 4
- Strip backticks before comparing to ignore file
- Ignore links per-crate? HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from cargo-intraconv.