if Cron('1 0 * * *'), getNext() will return next day 00:00:00 ? why not 00:01:00

if Cron('1 0 * * *'), about cron HOT 6 CLOSED

poliander commented on May 24, 2024

if Cron('1 0 * * *'),

from cron.

Comments (6)

poliander commented on May 24, 2024 1

I'll look again into this today.

from cron.

poliander commented on May 24, 2024

Thank you very much for pointing this one out.

from cron.

poliander commented on May 24, 2024

Fixed in version 1.2.1

from cron.

marshhj commented on May 24, 2024

Thanks for fixing! But the bug still exists........ And the fix bring new bugs.....

Cron('1 0 * * *'), getNext() will return next day 00:00:00 still exists !!!
Cron('0 0 * * *'), getNext() will return the day after tomorrow 00:00:00 !!!

from cron.

poliander commented on May 24, 2024

Okay, you're completely right - thank you again. The getNext() calculation was flawed when crossing month boundaries. I admit there should be more unit tests for that particular method.

The error should be fixed in current master branch. Would you be so kind and do a test? I also added another unit test for when "1 0 * * *" goes into next month.

from cron.

poliander commented on May 24, 2024

Fixed in version 1.2.2

from cron.

Recommend Projects