Code Monkey home page Code Monkey logo

Comments (7)

deanm0000 avatar deanm0000 commented on August 27, 2024 1

Actually, not a coincidence I saw the bump and it reminded me of asking for this default.

from polars.

mcrumiller avatar mcrumiller commented on August 27, 2024 1

Chiming in, I think pl.index() is better than pl.row_index(). It's simpler, and all horizontal expressions use horizontal_, so the "row" part is unnecessary.

It also seems to be a super obvious operation and very common to use, why is there any argument about it?

from polars.

cmdlineluser avatar cmdlineluser commented on August 27, 2024

Coincidentally, the pl.row_index() issue received a bump earlier today.

#12420

from polars.

deanm0000 avatar deanm0000 commented on August 27, 2024

@ritchie46 is this one ok to do or do you have any objections?

from polars.

Oreilles avatar Oreilles commented on August 27, 2024

This feels counter-intuitive to me: I would expect a range function called without specified bounds to raise.
Adding pl.row_index() (with the same implementation you propose) to the API would make more sense in my opinion.

EDIT: Furthermore, pl.int_range() could not be used as a join expression since it doesn't return an elementwise expression (see #12420 (comment))

from polars.

deanm0000 avatar deanm0000 commented on August 27, 2024

@mcrumiller I, for one, am not arguing against pl.index or pl.row_index or whatever other name it could have. It's just that those were already ruled out so this is a middle ground.

@Oreilles Lots of things are counterintuitive until you get used to them. That said, I don't really share that sense of it being counterintuitive since it exists in a context that has a length that is a natural default so why not make it the default?

from polars.

Oreilles avatar Oreilles commented on August 27, 2024

Intuitiveness certainely is subjective, but using pl.int_range() to generate an index has some drawbacks that would cripple its use case compared to an actual row_index function.

  • int_range doesn't reflex the intent in the way row_index or with_row_index does (would with_int_range make sense ? Maybe, but arguably less intuitively).
  • int_range defaults to Int64 and index columns generated with with_row_index are UInt32, so they cannot be merged on by default.
  • int_range cannot be used as a join expression... which would likely be the primary use case for using it instead of with_row_index (see #12420 (comment))

from polars.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.