Code Monkey home page Code Monkey logo

Comments (11)

pojntfx avatar pojntfx commented on May 31, 2024

@zeigerpuppy Sorry for taking so long to respond; I've been quite busy at uni these past few days. The error appears to be related to node-gyp; @rzerres is working on PR #3 right now, which does no longer rely on native grpc and should fix your issue.

from nextcloud-talk-bot-jitsi.

pojntfx avatar pojntfx commented on May 31, 2024

@zeigerpuppy I've just merged PR #3 into master; the package does now no longer depend on node-gyp, so this should now fixed. Could you validate?

from nextcloud-talk-bot-jitsi.

zeigerpuppy avatar zeigerpuppy commented on May 31, 2024

@pojntfx Thanks for updating the dependencies.

The build with docker-compose build --no-cache is throwing an error at step 6, seems to be a different dependency issue:

Step 6/7 : RUN npm ci
 ---> Running in be4cbd7fb994
npm ERR! cipm can only install packages when your package.json and package-lock.json or npm-shrinkwrap.json are in sync. Please update your lock file with `npm install` before continuing.
npm ERR!
npm ERR!
npm ERR! Missing: js-yaml@^3.13.1
npm ERR! Invalid: lock file's [email protected] does not satisfy yargs@^15.3.1
npm ERR! Missing: @grpc/grpc-js@^1.0.3
npm ERR! Missing: @grpc/proto-loader@^0.5.4
npm ERR!

npm ERR! A complete log of this run can be found in:
npm ERR!     /root/.npm/_logs/2020-05-17T04_19_09_717Z-debug.log
ERROR: Service 'nxtalkchatbots' failed to build: The command '/bin/sh -c npm ci' returned a non-zero code: 1

from nextcloud-talk-bot-jitsi.

pojntfx avatar pojntfx commented on May 31, 2024

@zeigerpuppy Sorry, my bad; I forgot to push the updated package-lock.json. npm i does not care, but npm ci does - see 22277ed.

from nextcloud-talk-bot-jitsi.

zeigerpuppy avatar zeigerpuppy commented on May 31, 2024

great, it is building now, but I note that there is an error thrown due to unknown arguments: jitsiRoomPasswordByteLength, sleepTime, nxtalkproxydAddr

nxtalkchatbots    | Unknown arguments: jitsiRoomPasswordByteLength, sleepTime, nxtalkproxydAddr
nxtalkchatbots    | npm ERR! code ELIFECYCLE
nxtalkchatbots    | npm ERR! errno 1
nxtalkchatbots    | npm ERR! @pojntfx/[email protected] start: `node main.js`
nxtalkchatbots    | npm ERR! Exit status 1
nxtalkchatbots    | npm ERR!
nxtalkchatbots    | npm ERR! Failed at the @pojntfx/[email protected] start script.
nxtalkchatbots    | npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

in my docker-compose.yml, I am using the environment variables:

        environment:
            NCTALKBOT_JITSI_ADDR: "jitsi.server.net"
            NCTALKBOT_BOT_NAME: "jitsibot"
            NCTALKBOT_SLEEP_TIME: 20
            NCTALKBOT_NXTALKPROXYD_ADDR: "nxtalkproxyd:1969"
            NCTALKBOT_JITSI_ROOM_PASSWORD_BYTE_LENGTH: 1
            NCTALKBOT_COMMANDS: "#videochat,#videocall,#custom"

from nextcloud-talk-bot-jitsi.

rzerres avatar rzerres commented on May 31, 2024

@zeigerpuppy may you check the correct env name for the proxy address?
With the merge it should be

environment:
  ...
  NCTALKBOT_NCTALKPROXYD_ADDR: "<hostname>:<port>"
  ...

And you can run the generated bot binary in debug mode. That should give you verbose console output with the parsed environment variable resolutions.

from nextcloud-talk-bot-jitsi.

zeigerpuppy avatar zeigerpuppy commented on May 31, 2024

Thanks for the tip, looks like I misspelled the new variables, I have corrected the variable names, which has fixed the issue with the NCTALKBOT_NCTALKPROXYD_ADDR variable

It looks like the numeric arguments are not getting parsed. Which I guess may be something to do with the way that docker-compose handles variables:

Unknown arguments: jitsiRoomPasswordByteLength, sleepTime

Sorry for asking an obvious question, but how do I enable the debug mode?

from nextcloud-talk-bot-jitsi.

pojntfx avatar pojntfx commented on May 31, 2024

@zeigerpuppy Sorry for taking so long (Uni took some time), but here we go. @rzerres Has implemented the debug code, to use it you currently have to go to

and uncomment it. If I have the time in the future, I'll be continuing work on a rewrite in Go for this based on chromedp and headless_shell, but well. Considering the numeric values: Have you tried passing them as strings? As far as I know yargs uses parseInt for numeric args so that should work.

from nextcloud-talk-bot-jitsi.

pojntfx avatar pojntfx commented on May 31, 2024

Oh and in case you need a fallback: The old bot image (pojntfx/nextcloud-talk-bot-jitsi) it still API-compatible with nctalkproxyd.

from nextcloud-talk-bot-jitsi.

zeigerpuppy avatar zeigerpuppy commented on May 31, 2024

Thanks for the tips.
I don't think the environment variables are being called at all when the container starts.
Looking at the code a bit more, it seems that the variables are actually coming through from nextcloud-talk-bot-jitsi/etc/nctalkbot-jitsi.yml.
I tried strings and also tried adding default values in the main.js and removing them from my docker-compose.yml. This resulted in the comtainer starting properly, but with only the default values.
There doesn't seem to be anywhere that I can see where the environment variables are used by the program.

from nextcloud-talk-bot-jitsi.

pojntfx avatar pojntfx commented on May 31, 2024

@zeigerpuppy Sorry for taking so long, this issue seemed to have slipped under my radar; I've addressed the issue. Would you mind testing?

PS: Sorry for the issue itself; I kinda just merged the last PR w/o much consideration and apparently said feature wasn't implemented.

from nextcloud-talk-bot-jitsi.

Related Issues (2)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.