Code Monkey home page Code Monkey logo

Comments (3)

tgrapperon avatar tgrapperon commented on August 23, 2024

Hey @acosmicflamingo! The other common error is forgetting to embed the child Reducer that hosts the BindingReducer into its parent. You can indeed check that the Home feature is not scoping any Setting reducer, which explains why it doesn't run at all.

If we add:

Scope(state: \.settings, action: /Action.settings) {
  Settings()
}

to Home.body, the message goes away and the sliders are updating.

The SettingPreview doesn't have any issue because it runs the Settings reducer by construction.

This is very likely an omission from the ReducerProtocol conversion, albeit I'm not familiar enough with the codebase to decide if this is the correct way to embed this feature here. I'll check how it looked like before, and I'll eventually PR.

from isowords.

acosmicflamingo avatar acosmicflamingo commented on August 23, 2024

Hello there @tgrapperon ! Nice to meet you :) Thanks for the helpful info AND even creating a PR :D definitely makes sense. Since you say it's common, perhaps it'd be beneficial for this to be documented somewhere. So I created this PR: pointfreeco/swift-composable-architecture#1729

from isowords.

stephencelis avatar stephencelis commented on August 23, 2024

This was fixed awhile back, and we finally converted our old style of shared settings state to use a proper dependency here: #186. Thanks for filing the issue though!

from isowords.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.