Comments (3)
Hey @acosmicflamingo! The other common error is forgetting to embed the child Reducer that hosts the BindingReducer
into its parent. You can indeed check that the Home
feature is not scoping any Setting
reducer, which explains why it doesn't run at all.
If we add:
Scope(state: \.settings, action: /Action.settings) {
Settings()
}
to Home.body
, the message goes away and the sliders are updating.
The SettingPreview
doesn't have any issue because it runs the Settings
reducer by construction.
This is very likely an omission from the ReducerProtocol
conversion, albeit I'm not familiar enough with the codebase to decide if this is the correct way to embed this feature here. I'll check how it looked like before, and I'll eventually PR.
from isowords.
Hello there @tgrapperon ! Nice to meet you :) Thanks for the helpful info AND even creating a PR :D definitely makes sense. Since you say it's common, perhaps it'd be beneficial for this to be documented somewhere. So I created this PR: pointfreeco/swift-composable-architecture#1729
from isowords.
This was fixed awhile back, and we finally converted our old style of shared settings state to use a proper dependency here: #186. Thanks for filing the issue though!
from isowords.
Related Issues (20)
- `make bootstrap-client` fails (words/SQL issue?) HOT 2
- make bootstrap-client does not fetch image assets HOT 10
- Cube is incorrectly sized after rotation on iPad HOT 1
- Various layout issues when iPad app is in compact width
- Will the `OptionalPaths.swift` be moved to the `CasePaths` package? HOT 1
- No file prompt when creating new files in the `isowords` local package HOT 1
- isowords is running audio and using battery even when the isowords audio settings have turned audio off. HOT 2
- Android? HOT 1
- Mostly Empty Project HOT 2
- `isowords` app target missing HOT 1
- Change my user name? HOT 2
- Gh
- Dr
- Daily Challenge Unlimited button doesn't fade when ending a game immediately HOT 2
- Text truncation issues for onboarding screens with Accessibility text sizes HOT 1
- Mimicking the modular structure of this app HOT 2
- unexpected service error: “multiple configured targets of \’CubeCore\’ are being created for iOS Simulator” HOT 6
- Can't set a custom icon on iPad HOT 1
- [Feature] - Time limit for multiplayer mode HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from isowords.