Episode.feedId has become Episode.feedid? about docs-api HOT 10 CLOSED

Can confirm. The episode objects in the output for api/1.0/episodes/byfeedid used to have a key called feedId. This is now changed in feedid. My guess is this is why the test fails.
Also, if i'm not mistaken the key feedTitle has been removed entirely.
edit: forgot the fancy code blocks, ty :p

from docs-api.

Ok, fixed. Please confirm it looks right on your side now.

@Siebe I don't see any record of ever having feedTitle in that call response. Do you need it?

from docs-api.

I see those being returned in "recent/episodes" but not in the commit history of "episodes/byfeedid". I wonder if he synthesized from that. Regardless, they should probably match. I'll make that change.

from docs-api.

Let me check. Could be a typo.

from docs-api.

I don't see any breaking changes. It still works like it always has. I looked at your unit test and it seems to be defined correctly. Not sure. How is it breaking? What's the failure you're seeing?

from docs-api.

Ya, js variables are case-sensitive and it seemed like it changed from feedId to feedid.

I can't confirm the feedTitle change, but I too was looking to use it via Episode and also noticed it wasn't there.

from docs-api.

Ah, my bad. I misunderstdood. You were talking about the output, not the url. Let me check.

from docs-api.

I'm pretty sure feedTitle used to be in there as well, and perhaps even feedLanguage?
I believe @RyanHirsch keeps a neatly overview in typescript
https://github.com/RyanHirsch/podcastdx-client/blob/master/src/types.ts

And no, I don't need it. I just wouldn't recommend changing or removing keys, only adding new ones. Until you you version up of course.

from docs-api.

Yes I've found some gaps in my types. I'm going to try and address them today.

from docs-api.

Seems like this is solved so I'm going to close this.

from docs-api.