Use clang-tidy in project about poco HOT 5 OPEN

Maybe something like this for external files.

I still need to prototype a little bit. We probably still do not want to build these as libs as before. Also we probably want to have nice include paths

#include "Poco/external/pdjson/pdjson.h"

We could also do some magic that we can always do that even when POCO_UNBUNDLED is used. But that is not very high priority but would be nice.

from poco.

I propose to split the structure reorganisation of external files as an enhancement to a separate issue, because it can be done independently from using clang-tidy.

Regarding includes: AFAIK Poco uses the includes only internally and it does not export them for Poco users. My proposal for includes is that an include path is set for each bundled library in such a way that it can be used in the same way as for unbundled libraries from Poco sources.

from poco.

Structure reorganization is needed if we want to have clang-tidy automated in good way. Else we will clatter with exclude rules. That would be same work as moving files to different location. Moving them will also help in other stuff like taking clang-format in use.

Easiest reorganization would be this

Foundation/src/External/
Foundation/include/Poco/External/

This way almost nothing change but we can exclude those pretty easily.

from poco.

I know that it is needed. However restructuring can be done independently of clang-tidy as a separate task. Then clang-tidy can be added on top.

from poco.

You are free to do seperete task for it and edit this one.

from poco.