Code Monkey home page Code Monkey logo

Comments (5)

aleks-f avatar aleks-f commented on March 29, 2024

I'd think Foundation_API can be hardcoded inside the macro, rather than passed as macro parameter. I'm not sure if it was done with it as parameter to pacify a compiler. Günter may have an answer to that.

from poco.

obiltschnig avatar obiltschnig commented on March 29, 2024

No, the macros are also used by other libraries. For example, XML would use XML_API instead of Foundation_API.

On 04.12.2012, at 14:56, Aleksandar Fabijanic wrote:

I'd think Foundation_API can be hardcoded inside the macro, rather than passed as macro parameter. I'm not sure if it was done with it as parameter to pacify a compiler. Günter may have an answer to that.


Reply to this email directly or view it on GitHub.

from poco.

tinobog avatar tinobog commented on March 29, 2024

Could FOUNDATION_API (and XML_API for that matter) not be set to some sensible value for gcc. I see that shared library export can also be improved for gcc builds: http://gcc.gnu.org/wiki/Visibility.
Maybe one could set it to

#if GNUC >= 4
#define FOUNDATION_API attribute ((visibility ("default")))
#else
#define FOUNDATION_API
#endif

from poco.

aleks-f avatar aleks-f commented on March 29, 2024

It seems ok to me.

from poco.

aleks-f avatar aleks-f commented on March 29, 2024

tinobog: can you please do the changes, build, run tests and submit a pull request for this request? I do not think I'll have time to do it for 1.5.1

from poco.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.