Code Monkey home page Code Monkey logo

Comments (4)

dietergeerts avatar dietergeerts commented on July 30, 2024 3

As a side note: I don't think having the info around the preview is bad, it's actually the thing you want for styleguides, BUT it's the fact that they are both in the same iframe that's not good. So if only storybook would allow plugins to put things around the iframe...

from storybook-addon-vue-info.

pocka avatar pocka commented on July 30, 2024

+1 for first one: I think it's not possible to render component in <iframe> with Vue.

I strongly agree that wrapping actual component with info isn't good, and also Storybook team seems to think so.
We should add options that moves info into addon panel. After storybookjs/storybook#1501 is merged, we can set it as default.

I didn't look at the code, but I assume it isn't that much work to add the option to render the info in a side panel?

Sorry, I don't know whether it's easy or not (I'm not familiar with addon panel...).

from storybook-addon-vue-info.

kyleoliveiro avatar kyleoliveiro commented on July 30, 2024

I agree with having it in a panel as opposed to in an iframe. Currently, the addon-a11y plugin throws errors due to the stuff that addon-vue-info adds into the iframe.

from storybook-addon-vue-info.

pocka avatar pocka commented on July 30, 2024

Implemented in #70 (version 1.0.0-alpha.7)

from storybook-addon-vue-info.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.