clang-tidy fails due to warnings in non-user code about pre-commit-hooks HOT 6 CLOSED

Actually, it only seems to exit with code 1 through pre-commit. If I invoke clang-tidy directly, it shows the warnings were suppressed but exits with code 0.

$ clang-tidy --fix -p cmake-build-debug src/main.c
2816 warnings generated.
Suppressed 2816 warnings (2816 in non-user code).
Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well.
$ echo $?
0

clang-tidy...............................................................Failed
- hook id: clang-tidy
- exit code: 1

2816 warnings generated.
Suppressed 2816 warnings (2816 in non-user code).
Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well.

repos:
    - repo: https://github.com/pocc/pre-commit-hooks
      rev: v1.3.3
      hooks:
          - id: clang-format
            args: [-i, --style=file]
          - id: clang-tidy
            args: [--fix, -p=cmake-build-debug]

My solution for now is to use a local hook:

repos:
    - repo: local
      hooks:
          - id: clang-tidy
            name: clang-tidy
            description: Statically analyse files with clang-tidy.
            entry: clang-tidy --fix -p=cmake-build-debug
            language: system
            types: [c]

Frankly, I don't really see what the clang-tidy hook here has to offer over the above.

from pre-commit-hooks.

What version of llvm are you using? What OS are you on? The test ok file uses <stdio.h> and the test passes. I'll take a look at it.

from pre-commit-hooks.

Can you provide your src/main.c as well (or a link to the repo that has it)? I'm not able to replicate this on Linux or Macos.

from pre-commit-hooks.

Adding some tests for double-dash arguments -- --std=c++20, I got a test that failed (try using -- args with your local hook). I'm guessing the default language target on your system is higher than mine?

Most recent commit is 661e54b - can you set rev to that and see if you still have issues?

from pre-commit-hooks.

Sorry for a late response. I did get together a minimal reproducible example, but I tried that new ref, and it indeed fixes the issue. I was going to point out that clang-tidy was outputting to stderr and the hook always failed if it saw anything in stderr, but you caught onto that already.

For posterity, I suppose I'll attach the example anyway since I already made it. It can be reproduced through Docker.

test.zip

I'm guessing the default language target on your system is higher than mine?

I don't know; I specify it through CMake. I thought clang-tidy somehow determines the language target by reading compile_commands.json.

from pre-commit-hooks.

Looks like your language target is C 99. I added this as a test in tests/test_iss36.py.

Thanks for providing your example files.

from pre-commit-hooks.