Offset thumbnail decorations with MPV-EASY about thumbfast HOT 9 CLOSED

There's a latency inherent in the current rendering model, scripts can avoid it by using the custom render functionality but the current implementation is a pain to deal with.
There's a PR to uosc that uses it, and it does seem to fix the issue.
I've thought about forwarding serialized code to the UI script as a way to truly execute within their render loop without requiring extra work from them, but I'm sure there's a less intrusive solution.
Suggestions appreciated.

from thumbfast.

Regarding that PR, I'm still waiting for your verdict on that proposed new API :) → tomasklaen/uosc#353 (comment)

from thumbfast.

@po5 Can you link me the PR please? Couldn't find it.

from thumbfast.

@First-Dan tomasklaen already linked to it in the comment above yours.

from thumbfast.

It's working now, but I didn't use the solution provided by the PR becasue i didn't know what to do with it (lol).
I managed to fix it by switching to the original mpv player, because i was using a different fork of mpv called mpv easy player which also had support for vanilla UI and scripts, except for Thumbfast. I guess @po5 had nothing to do with this issue from the beginning but it was something to do with that fork.

Thank you everyone for your help nonetheless!

from thumbfast.

@First-Dan Were you actually using thumbfast in that screenshot?
I'd like to copy your configuration to replicate it, if you can link to the scripts you were using.
I thought this was #11, but if the thumbnail is always off it's more likely an issue in the UI script.

Okay, MPV-EASY does something weird that breaks decoration positioning.

from thumbfast.

@First-Dan and any other users of MPV-EASY, can you confirm that 74cba1f fixes the issue? (update osc.lua)
This misalignment is what happens when the default ASS alignment is 9 (top-right), Syncplay had 1 (bottom-right). We expected it to be 7 (top-left), and that is now explicitly specified.

from thumbfast.

Confirmed to work here 1-minute-to-midnight/mpv-modern-x-compact#7 (comment)

from thumbfast.

It was caused by non-default osd-align-x/y values in both Syncplay and MPV-EASY.

https://github.com/422658476/MPV-EASY-Player/blob/f281e7ace9b276dc4aee595c8da1b2093a01f491/mpv-easy-data/rjno1.conf#L11

from thumbfast.