Comments (5)
@jkyberneees I'm doing some cleanup on Hydra-Router that will make this an easier conversation to have. Specifically, the HydraRouter routeRequest
function is too large and in need of refactoring. Feedback on your points above to follow...
from hydra-router.
Great, I keep an eye on this.
from hydra-router.
@jkyberneees please see if hydra-router 1.3.1 addresses this issue. Also requires that the service themselves using the latest hydra / hydra-express as updates are in makeAPIRequest.
from hydra-router.
@cjus Hi Carlos, thanks for taking care of the issue/feature/suggestion.
I reviewed the code and I see that you inject the request headers and consider the response too, however I don't understand this exclusion: https://github.com/flywheelsports/hydra/blob/master/index.js#L1103
Unfortunately, the feature is not yet working as expected, since hapi services are still not properly routed ;(
Let me know if you need more details to reproduce.
Best Regards, Rolando
from hydra-router.
@jkyberneees the line you referenced checks whether instanceList.length is zero - if that's the case then there are no more service instances to try so a service unavailable response is necessary. The 1.3.1 release was found to have problems - please see if the issue is resolved in hydra-router:1.3.8
from hydra-router.
Related Issues (20)
- Support for private routes HOT 7
- Get currently connected clients HOT 5
- hydra-router not processing application/x-www-form-urlencoded request HOT 2
- Creating an API Gateway HOT 6
- Docker cannot connect to Redis HOT 12
- "Overlapping" routes HOT 3
- Hydra-router / Docker Swarm / AWS: Getting SIGTERM HOT 8
- hydra-router not routing request to worker service in docker swarm cluster HOT 4
- Time drift issue when running hydra-router in a docker swarm on a Mac. HOT 3
- A service aware router for Hydra Services HOT 10
- Routing not working HOT 2
- Hydra-router request timeout is not passed to Hydra Core HOT 4
- Document each entry in the routers config
- Improve config field/param loading
- cant proxy/process file uploads/downloads via hydra-router
- Use module logger utility HOT 2
- queuer redis db shouldn't be hardcoded HOT 2
- Router doesn't correctly report service unavailable? HOT 3
- _handleRouterRequest allows access when no token is set HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from hydra-router.