Updating to pnpm 9 cause `pnpm install` to look for a workspace dependency on npm about pnpm HOT 3 CLOSED

CraigMacomber/FluidFramework#4

from pnpm.

CraigMacomber/FluidFramework#4

I can confirm that (setting link-workspace-packages=true) fixed our issue. Thank you for the fix or maybe its a workaround? Either way, I'm happy to have it!

Given all references to the requested version explicitly use "workspace:~", and it worked fine in pnpm 7 and 8, I think this might still be a regression, so maybe this bug should stay open.

Reading https://pnpm.io/workspaces#workspace-protocol-workspace : (Emphasis added)

By default, pnpm will link packages from the workspace if the available packages match the declared ranges. For instance, [email protected] is linked into bar if bar has "foo": "^1.0.0" in its dependencies and [email protected] is in the workspace. However, if bar has "foo": "2.0.0" in dependencies and [email protected] is not in the workspace, [email protected] will be installed from the registry. This behavior introduces some uncertainty.

Luckily, pnpm supports the workspace: protocol. When this protocol is used, pnpm will refuse to resolve to anything other than a local workspace package. So, if you set "foo": "workspace:2.0.0", this time installation will fail because "[email protected]" isn't present in the workspace.

This protocol is especially useful when the link-workspace-packages option is set to false. In that case, pnpm will only link packages from the workspace if the workspace: protocol is used.

Based on my interpretation of that:

1. link-workspace-packages=true should only be needed if we don't use "workspace" versions, and we do use them.
2. Even if we didn't use "workspace" versions, since the requested version is in the workspace, it should resolve to the version in the workspace, not search npm, even without link-workspace-packages=true.

The observed behavior is its searching npm, and failing to find the package despite it being in the workspace, and using a workspace version, both of which should have prevented it from searching npm. link-workspace-packages=true changes this, causing it to search the workspace for the workspace version, which it finds.

If this is intended behavior, I think those docs need updating for pnpm 9.

from pnpm.

@CraigMacomber I was able to find this fix quickly because I've read pnpm 9 breaking changes and knew that link-workspace-packages had been changed to false by default (it was true by default in pnpm 8).

Anyway, thanks for pointing out outdated documentation. I will correct it.

from pnpm.