Code Monkey home page Code Monkey logo

Comments (17)

lafe avatar lafe commented on August 28, 2024 5

@akashpanjwani If you have immediate need to fix the issue, you can use the patch-package package and modify the "SPTaxonomyService.js" located in "/node_modules/@pnp/spfx-controls-react/lib/services" so that it uses the stringMatchOption property with the value StartsWith. Afterwards, it should work again.
That was the approach we choose until a permanent fix is implemented (I provided PR #1704, but we will see if it is accepted or if I oversaw a use case).

from sp-dev-fx-controls-react.

akashpanjwani avatar akashpanjwani commented on August 28, 2024 2

@lafe It works Thanks.

from sp-dev-fx-controls-react.

joelfmrodrigues avatar joelfmrodrigues commented on August 28, 2024 2

@raclettierer many thanks for confirming, we are discussing/planning when to do the next main release

from sp-dev-fx-controls-react.

lafe avatar lafe commented on August 28, 2024 1

SPTaxonomyService.js.zip

If it is necessary to urgently resolve this issue, unpack this archive and replace the file "/node_modules/@pnp/spfx-controls-react/lib/services/SPTaxonomyService.js" with the one in the archive. Or make changes manually. Changes

I would recommend to use patch-package or a similar approach instead of manually editing the file. This ensures that the changes are not overwritten by accident, that they are commited to source control, that every developer has the same changes and that you still can use build pipelines (if none of that is a concern, then the benefit is obviously not as big).

@lafe Thank you for your work!

The main work was done by @amy-woods who already outlined the solution in the issue itself. Thank you for that!

from sp-dev-fx-controls-react.

raclettierer avatar raclettierer commented on August 28, 2024 1

@joelfmrodrigues Fix works in my projects (used 3.17.0-beta.7718771)

from sp-dev-fx-controls-react.

 avatar commented on August 28, 2024

Thank you for reporting this issue. We will be triaging your incoming issue as soon as possible.

from sp-dev-fx-controls-react.

github-actions avatar github-actions commented on August 28, 2024

Thank you for submitting your first issue to this project.

from sp-dev-fx-controls-react.

sajdak-codes avatar sajdak-codes commented on August 28, 2024

I have the same issue as well. It started today. I am using library version 3.13.0.

Edit: I failed to mention I had checked the API endpoint on 2 different tenants. On one of them "stringMatchingId" works, on the other it does not.

from sp-dev-fx-controls-react.

robertmacnair avatar robertmacnair commented on August 28, 2024

I have the same issue. Appears stringMatchId has been deprecated / removed from the underlying API... stringMatchOption works. TaxonomyService needs updating I suspect

from sp-dev-fx-controls-react.

JurajSlavik avatar JurajSlavik commented on August 28, 2024

We have detected the same behavior on 15-th of November 2023. On 9-th of November 2023, the ModernTaxonomyPicker used to work without any problems.

Probably not required here, but adding used dependencies versions in this case (taken from package.json):
"@microsoft/sp-core-library": "1.16.1",
"react": "17.0.1",
"react-dom": "17.0.1"

Just in case someone needs a workaround until this will be fixed - Tag icon (highlighted) on the right side of the control works without any problems (if you dont need autocomplete):

image

Of course, this is usable only if there is not too much items to show.

We also figured, that https://pnp.github.io/sp-dev-fx-controls-react/controls/TaxonomyPicker is not affected with this issue and it works as expected. This can be used as an alternative, until some specific functionality from ModernTaxonomyPicker is not required.

from sp-dev-fx-controls-react.

akashpanjwani avatar akashpanjwani commented on August 28, 2024

we are also facing same issue in multiple applications. please let me know in case of any workarounds we have more than 1000 values in sets.

from sp-dev-fx-controls-react.

Tejasdarji24 avatar Tejasdarji24 commented on August 28, 2024

Still, I am facing the same error.

image

Is there an alternate solution? I know about taxonomy pickers but I strongly believe in using modern taxonomy pickers.

any suggestion?

cross finger to resolve this issue ASAP.

Thanks

from sp-dev-fx-controls-react.

Foster117 avatar Foster117 commented on August 28, 2024

Our company has lots forms with this control, please fix this issue as soon as possible. Thank you!

from sp-dev-fx-controls-react.

Foster117 avatar Foster117 commented on August 28, 2024

SPTaxonomyService.js.zip

If it is necessary to urgently resolve this issue, unpack this archive and replace the file "/node_modules/@pnp/spfx-controls-react/lib/services/SPTaxonomyService.js" with the one in the archive. Or make changes manually.
Changes

@lafe Thank you for your work!

from sp-dev-fx-controls-react.

IngoHenning avatar IngoHenning commented on August 28, 2024

We use this control in multiple spfx solutions and I received "some" mails from not so happy users since last week. For the time being I applied the changes made in the pull request from @lafe as patch - Thank you for your work! Hopefully the pull request get's merged soon.

from sp-dev-fx-controls-react.

raclettierer avatar raclettierer commented on August 28, 2024

Any news on this bug ?

from sp-dev-fx-controls-react.

joelfmrodrigues avatar joelfmrodrigues commented on August 28, 2024

Hi all, really sorry for the delay in reviewing this item and that it's causing issues for so long.
The PR is now merged and the fix will be in the beta release in a few minutes. It would be great if someone can confirm that it resolves the issue using the beta release.
Considering the impact, we will start discussions for the next release.

from sp-dev-fx-controls-react.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.