Typescript def for 'sp' config in @pnp/common 'setup' function is not available about pnpjs HOT 4 CLOSED

Hi @alirobe,

Any specific reason to import setup from @pnp/common but not from @pnp/sp?

import { sp } from "@pnp/sp";

sp.setup({
  sp: {
    headers: {
      "Accept": "application/json;odata=verbose"
    }
  }
});

from pnpjs.

There are different setup methods in play here. There is a core setup method in common that handles any shared configuration. What you want is the setup method from the @pnp/sp library. That includes the type you expect. @koltyakov 's example above is correct. The sp.setup is an extension of the setup method from common. It works because ultimately the configuration ends up in the same object behind the scenes, you are just lacking the typing.

Docs page shows the use of the sp specific configuration.

from pnpjs.

OK, I think I read some incorrect guidance somewhere - but I can't remember where, so I think I'll just close this. Fix works. Thanks for the answer :)

from pnpjs.

This issue is locked for inactivity or age. If you have a related issue please open a new issue and reference this one. Closed issues are not tracked.

from pnpjs.