Context / SPFetchClietn breaks when multiple requests come into ExpressJs about pnpjs HOT 4 CLOSED

Hi @MarkusFeldmann,

Are all the sites the Express app talking to share the same credentials?

By using pnp.sp.web the lib tries detect a default baseUrl, it's more a browser's approach. But even in a browser solution, it's better using explicit Web object initiation with strictly providing web URL. Which is definitely a the case for a Node.js application:

For instance:

import { Web } from '@pnp/sp';

const web = new Web('[web_absolute_url]');
web.get().then(w => {
    log.info("[START] Creating metadalist in web %s", siteUrl);
    web.lists.ensure('metadata').then(ler => {
// [...]

This should exclude situations with unpredictable web paths.

Whereas, credentials can't be switched so easily yet this is not important while it's the same clientId/appSecret and the same site collection all the way. Otherwise, with different creds for different methods, sp.setup({ sp: { fetchClientFactory: () => ... } } should be called before each physical request (this scenario is not recommended, IMO, at least we need some design work as this fetch client is global). @patrick-rodgers, please correct me if I'm wrong on this last part.

Hope this helps.

from pnpjs.

Hi @koltyakov
Yeah, last night I had a deeper look into the library and found that the approach stores the context globally. So as I am on a schedule I converted the whole thing to to promise based rest. In fact it would be really nice to be able to do it like with C#'s CSOM approach, create a context and simply use it for the request / operation at hand.

anyway: thx
best regards,
Markus

from pnpjs.

I guess we could consider potential context-related enhancements or techniques for multi-contextual (different SiteCollections/credentials) tasks in Node.js/server-side scenarios with PnPjs. Especially in case of growing demand.

Meanwhile, I'm going to close this issue as answered. In a situation with the same credentials, creating new Web('[abs_ur]') should definitely be the cake.

from pnpjs.

This issue is locked for inactivity or age. If you have a related issue please open a new issue and reference this one. Closed issues are not tracked.

from pnpjs.