Code Monkey home page Code Monkey logo

Comments (10)

redepandence avatar redepandence commented on June 12, 2024

Hi guys,

the issue resolved , it is because 'AllowedTenants' in the Provision-ModernizationFramework.ps1 used the wrong parameter.

another question:

When I setting the appsetting according to the script Provision-ModernizationFramework.ps1, the below two properties will return "Bad Request"
WEBSITE_CONTENTSHARE
WEBSITE_CONTENTAZUREFILECONNECTIONSTRING

I tried to set these properties at Azure resources application, the error is the same, why this issue occurred? is it because the AAD updated some new logic in backend? what will effect if not set these properties ?

from modernization.

jansenbe avatar jansenbe commented on June 12, 2024

Hi @redepandence,

The AllowedTenants setting can be ignored, if the setting is emty or not there then we're not checking for tenant names. This feature is there for if you want to share the same Azure transformation service across multiple tenants. Doing so does require you to configure the service for multi-tenant usage first.

The WEBSITE_CONTENTSHARE and WEBSITE_CONTENTAZUREFILECONNECTIONSTRING properties are "system" properties of an Azure Function Host...you don't need to manually set them in the Azure Function host app. Or did you get a failure while running the Provision-ModernizationFramework.ps1 script?

Note that I'm also about to release the beta version of this tool, which does have a big performance improvement for the page transformation part.

from modernization.

redepandence avatar redepandence commented on June 12, 2024

Hi @jansenbe

Thanks for you quick response, your answer is very helpful.

"setting WEBSITE_CONTENTSHARE and WEBSITE_CONTENTAZUREFILECONNECTIONSTRING, did you get a failure while running the Provision-ModernizationFramework.ps1 script?"
The answer is yes, the script is trying to set these two properties, however the API Set-AzureRmWebApp will return "Bad Request" if the appsettings contain these two properties, I also trying to set these two properties at Azure function host app in Azure instead of by script but get the same result, I am not sure what will effect on if I cannot set it and if it effect nothing then I will ignore these two properties.

May I know the estimated date for release the beta version?

BR,
Thanks!

from modernization.

jansenbe avatar jansenbe commented on June 12, 2024

I'll test the script again and see if these 2 settings can be dropped. Beta will be available by end of next week.

from modernization.

jansenbe avatar jansenbe commented on June 12, 2024

but you got it to work eventually?

from modernization.

redepandence avatar redepandence commented on June 12, 2024

Yes, it works now , the appsettings can be updated successfully after removing WEBSITE_CONTENTSHARE and WEBSITE_CONTENTAZUREFILECONNECTIONSTRING although I don't know what will impact if not update these two properties. by the way, do you will continue to implement the unsupported webpart? the webpartmapping.xml seems have many webparts not have the befitted modern webpart to map :-)

from modernization.

jansenbe avatar jansenbe commented on June 12, 2024

Perfect. I've created #28 and will test this before the beta release. Since the tool works for you I'll now close this issue. Thanks for the testing and feedback, really appreciated!

from modernization.

jansenbe avatar jansenbe commented on June 12, 2024

About the webpartmapping.xml file: the ones that don't have a mapping today don't have an equivalent 1st party modern webpart. Our telemetry has shown that 90%+ of the pages can be modernized using the current mapping. If you need content or script editor you can adjust your mapping as explained in issue #26.

from modernization.

jansenbe avatar jansenbe commented on June 12, 2024

Hi @redepandence,

I do have one question: do you have your Azure Function app on a consumption plan or a standard plan? The 2 settings that gave an error can only be used on a consumption plan.

from modernization.

jansenbe avatar jansenbe commented on June 12, 2024

Hi @redepandence ,

There was one more reason for this issue: if you've used a character that's forbidden in a storage account name inside the function app name (e.g. uppercase character) then the WEBSITE_CONTENTSHARE property got populated with an invalid value. This will be fixed in the provisioning script but thought it would be interesting for you to know as well.

from modernization.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.