Enable AVX2 by default about php-binaries HOT 9 CLOSED

I am concerned that running on a wrong CPU would cause very unpredictable undefined behavior silently. Or are we confident that machines that do not support AVX2 will generate garbage output before it actually runs something in production to cause some damage?

What about we provide AVX2 binaries separately first and detect that we can use these binaries in install.sh?

from php-binaries.

Attempted usage of AVX2 instructions will cause an immediate crash with SIGILL since the host processor won't recognize the instruction.

In any case, as it turns out, some stuff such as libdeflate already compiles AVX2 code anyway, and uses cpuid() to switch the used function at runtime depending on what features the processor supports, so this isn't as big of a deal as I expected.

from php-binaries.

Attempted usage of AVX2 instructions will cause an immediate crash with SIGILL since the host processor won't recognize the instruction.

This is not exactly true. Other CPU models may interpret the same instruction code as something else and treat it differently.

from php-binaries.

I hadn't considered that, but since we're dealing with only two x86_64 vendors with known histories (AMD and Intel), I think that's probably not a concern.

from php-binaries.

I am not very familiar with various SIMD instruction sets, but it appears that AVX2 is already common enough. It is probably still a good idea for users to compile their own binaries to get the best performance though.

from php-binaries.

I think currently most people aren't aware that they are sacrificing performance by using prebuilt binaries instead of compiling their own, especially since installing a prebuilt is recommended by the docs, and is also done automatically by installer.sh.

from php-binaries.

(Binaries built using compile.sh without the -t flag will automatically use -march=native, so anyone building their own binaries automatically gets the best performance.)

Recently I've added this flag to my fork) I think I'll upload it this week..

from php-binaries.

-march=native makes binaries non-portable. There's a reason we don't use it for the prebuilts.

from php-binaries.

I think if someone could add detecting support of avx2 in runtime of already builded binary than enabling avx2 in prebuils will be good idea.

from php-binaries.