Code Monkey home page Code Monkey logo

Comments (9)

brettkettering avatar brettkettering commented on August 15, 2024

This only gets the svn version that it finds using plfs_get_svnversion.sh. Will that be good enough?

from plfs-core.

brettkettering avatar brettkettering commented on August 15, 2024

No, that script returns some number from SVN. We want the PLFS version. See trunk/VERSION and versions/2.1/VERSIONS as examples.

Talk to John B. and find out why he thought plfs.C's plfs_version returned what was in VERSION. Apparently it doesn't and I think it should. We're interested in the PLFS version, not the SVN version for the code library.

from plfs-core.

brettkettering avatar brettkettering commented on August 15, 2024

Looking at the configure.ac I think that plfs_tag() is the function that returns the proper version information. I'll talk to John at the meeting tomorrow to make sure.

from plfs-core.

brettkettering avatar brettkettering commented on August 15, 2024

So adding the version we want, namely the one we've been keeping track of in the VERSION file doesn't appear to be possible via SVN. At least not according to what I've been reading online. We can add the Rev number, but that won't give us the nice plfs version number we wanted. From what I've seen subversion doesn't keep track of tags in any meaningful way other than to make a copy of the directory.

It looks like we can get the modify date with a little bit of work using svn propset, but that looks to be about all we can do.

from plfs-core.

brettkettering avatar brettkettering commented on August 15, 2024

Thanks for looking into this TJ. Here's what I get when I run plfs_version:

/users/brettk> plfs_version
PLFS library:

2.1 (SVN exported, Built Oct 26 2011)

mount: /plfs/scratch1

Version 2.1 (SVN exported) (DATA 1.0) (LIB exported)
Build date: Oct 26 2011
Backend checksum: 3038

mount: /plfs/scratch2

Version 2.1 (SVN exported) (DATA 1.0) (LIB exported)
Build date: Oct 26 2011
Backend checksum: 3039

I think it would be good to have the "-version" flag on the other binaries return:

2.1 (SVN exported, Built Oct 26 2011)

and to have a plfs library function (in libplfs) called "get_plfs_version" (or something like that) that returns the same string to the caller.

Let's keep the actual plfs_version application too as it yields information about the mount points on the system.

Let's have you suggest the best way to do this at our next meeting. If it's using the VERSION file, fine. We need to document the things that must be done to generate a release and ensure the proper version gets set.

from plfs-core.

brettkettering avatar brettkettering commented on August 15, 2024

Also, should we have the build create libplfs-2.1, for example instead of always libplfs?

from plfs-core.

brettkettering avatar brettkettering commented on August 15, 2024

That way of doing the version option shouldn't be too difficult. Not sure about changing the libplfs name. It'll probably be fine if we add a symlink like libplfs -> libplfs-versionname, but I know virtually nothing about how that works so don't take my word for it.

from plfs-core.

brettkettering avatar brettkettering commented on August 15, 2024

Alright, the version options have been added to the tools, let me know what you think.

from plfs-core.

brettkettering avatar brettkettering commented on August 15, 2024

So, the -version option has been added and we have decided not to change the libplfs name to reflect the version information due to some complications with the mpi/io patch. Closing this ticket as of now.

from plfs-core.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.