Comments (5)
danielberndt
commented on May 15, 2024
Here's a different module setup where the issue occurs as well: https://github.com/danielberndt/play-requirejs-submodule-demo
from playframework.
wsargent
commented on May 15, 2024
Verified under 2.1.3-RC1.
➜ play21-assets-module git:(master) ✗ play stage
[info] Loading global plugins from /Users/wsargent/.sbt/plugins
[info] Loading project definition from /Users/wsargent/work/play21-assets-module/project
[info] Set current project to play21-assets-module (in build file:/Users/wsargent/work/play21-assets-module/)
[info] Packaging /Users/wsargent/work/play21-assets-module/modules/assets/target/scala-2.10/play21-assets-module-assets_2.10-1.0-SNAPSHOT-sources.jar ...
[info] Packaging /Users/wsargent/work/play21-assets-module/target/scala-2.10/play21-assets-module_2.10-1.0-SNAPSHOT-sources.jar ...
[info] Done packaging.
[info] Done packaging.
[info] Wrote /Users/wsargent/work/play21-assets-module/modules/assets/target/scala-2.10/play21-assets-module-assets_2.10-1.0-SNAPSHOT.pom
[info] Wrote /Users/wsargent/work/play21-assets-module/target/scala-2.10/play21-assets-module_2.10-1.0-SNAPSHOT.pom
[info] Packaging /Users/wsargent/work/play21-assets-module/modules/assets/target/scala-2.10/play21-assets-module-assets_2.10-1.0-SNAPSHOT-javadoc.jar ...
[info] Done packaging.
[info] RequireJS optimization has begun...
[info] app.build.js:
[info] ({appDir: "javascripts",
[info] baseUrl: ".",
[info] dir:"javascripts-min", modules: [{name: "main"}]})
[info] Generating Scala API documentation for main sources to /Users/wsargent/work/play21-assets-module/target/scala-2.10/api...
[info] Packaging /Users/wsargent/work/play21-assets-module/target/scala-2.10/play21-assets-module_2.10-1.0-SNAPSHOT.jar ...
[info] Done packaging.
Tracing dependencies for: main
Uglifying file: /Users/wsargent/work/play21-assets-module/modules/assets/target/scala-2.10/classes/public/javascripts-min/helper/lib.js
Uglifying file: /Users/wsargent/work/play21-assets-module/modules/assets/target/scala-2.10/classes/public/javascripts-min/main.js
Uglifying file: /Users/wsargent/work/play21-assets-module/modules/assets/target/scala-2.10/classes/public/javascripts-min/test.js
Uglifying file: /Users/wsargent/work/play21-assets-module/modules/assets/target/scala-2.10/classes/public/javascripts-min/test2.js
main.js
----------------
helper/lib.js
main.js
[info] RequireJS optimization finished.
[info] Packaging /Users/wsargent/work/play21-assets-module/modules/assets/target/scala-2.10/play21-assets-module-assets_2.10-1.0-SNAPSHOT.jar ...
[info] Done packaging.
model contains 17 documentable templates
[info] Scala API documentation generation successful.
[info] Packaging /Users/wsargent/work/play21-assets-module/target/scala-2.10/play21-assets-module_2.10-1.0-SNAPSHOT-javadoc.jar ...
[info] Done packaging.
[info]
[info] Your application is ready to be run in place: target/start
[info]
[success] Total time: 9 s, completed Jul 30, 2013 3:31:43 PM
from playframework.
huntc
commented on May 15, 2024
Verified as failing?
from playframework.
wsargent
commented on May 15, 2024
Yes, verified as failing.
On Tuesday, July 30, 2013, Christopher Hunt wrote:
Verified as failing?
—
Reply to this email directly or view it on GitHubhttps://github.com//issues/847#issuecomment-21836104
.
from playframework.
jroper
commented on May 15, 2024
Right, so the reason for this is primarily that Play's start command is a hack.
Play's start command tries to run the app in production mode without building any of the production artifacts (eg jar files), rather it adds the classes directories from each sub project to the classpath. Play's requireJs support is configured to run before the jar file is built.
The reason why it works for the root project is that we have a hack in the Play start command that explicitly runs it for the current project.
I think we could make this work by running the requireJs optimisation task for all aggregated projects, not just the current project, and that would fix this specific issue. But it wouldn't fix any other processing (eg gzip/md5 etc) that Play doesn't know about, and so also wouldn't work with the work we're doing now to pull client side tech support out of the core of Play.
I think the better fix to this would be to rewrite the play start command so that instead of using a completely different environment to the other prod modes, it first runs play stage, and then runs the start script produced by play stage. This will solve far more than just this issue.
I've raised a new issue here:
from playframework.
Related Issues (20)
- sbt-heroku plugin no longer maintained HOT 3
- `TestServer.isRunning` throws an exception when the server is not running. HOT 3
- Loss `Result` attributes by any modification HOT 4
- Requests with Large POST Body Immediately Goes into Delay Cancellation Right After the Server Received the Request HOT 6
- Caffeine cache API has inconsistent behavior with differing types and between sync/async HOT 1
- play hangs on console interacton when using jblas library HOT 4
- 2.9 with Scala 2.13 not supporting pack4j 6.00 dependency :Jackson Data-bind 2.15.x
- Documentation spelling fix HOT 3
- Scala 3.3.2: class file ... is broken, reading aborted with `class java.util.NoSuchElementException` `contextual$` HOT 9
- Replace `3.0.x` with next version HOT 5
- SSL certificate for www.playframework.com is expired HOT 2
- Search in documentation does not work HOT 1
- Support for Partitioned cookie attribute (AKA CHIPS) / make cookies more flexibel HOT 1
- Asset changes in subprojects HOT 2
- Recommend Scala Metals + VSCode as an IDE on this page: https://www.playframework.com/documentation/2.9.x/IDE HOT 1
- Timeout issue when using AsyncCacheApi and custom http filter HOT 2
- [2.8.20] CVE-2023-44487 in akka-http-core HOT 1
- Support for Application Secret rotation
- play 2.9 is trying to fetch guice-6.0.0-no_aop jar, caused not found error HOT 6
- Play gradle plugin fails to create playRun task when no compileScala task found in a project
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from playframework.