Rule idea: no-negated-ok about eslint-plugin-qunit HOT 4 CLOSED

Awesome, then this is accepted and I'll aim to put it in 0.8.0. Thanks!

from eslint-plugin-qunit.

Thanks for the issue!

As I noted in chat, one open question is whether or not we should also enforce negation in .notOk(). That could be done for free, or it could be made an option. To be honest I'm leaning towards just including it in the rule, since the whole point is to improve readability by avoiding a double negation. But it could also be done as an option.

What do you think? Is it worth having an option for the .notOk() case?

from eslint-plugin-qunit.

While I think the instances of .ok(!) will far outweigh the instances of .notOk(!), (since .notOk() is newer) I can't think of any reason someone would want one rule and not the other. I'd do them both as one since it should be easy to do.

from eslint-plugin-qunit.

I'll work on this today.

from eslint-plugin-qunit.