Comments (5)
Excellent call, agree that it should be on test and module callbacks, consider this accepted (until I can get to a desktop and apply the label).
Thoughts on rule name? I'm thinking no-arrow-tests
, but maybe you can do better, I'm feeling meh. Feel free to submit a PR
from eslint-plugin-qunit.
I'll start work on this.
@mitchlloyd Do you think there should be an option to tolerate arrow functions if they don't refer to this
? In theory, that shouldn't cause problems. (I would still want the default option to be outright forbidding arrow functions as test callbacks, though.)
from eslint-plugin-qunit.
I don't have any interest in allowing people to use both =>
and function
for defining test callbacks. I just don't see any advantage to allowing the =>
style.
from eslint-plugin-qunit.
@mitchlloyd I'm with you on that-- I'm just trying to figure out if there might be others who would want the linter to only flag it when someone is actually relying on this
in an arrow function.
It's easy to add this later if someone wants it, so I guess for now I'll go with no arrow functions period. In that case, I'm pretty close to having a branch ready.
from eslint-plugin-qunit.
I've put up a new branch. Could you take a look at the documentation in that branch to make sure I haven't misrepresented anything (especially about arrow functions, which I don't regularly use)? Thanks!
from eslint-plugin-qunit.
Related Issues (20)
- New Rule: `no-assert-unexpected-type` HOT 4
- New Rule: `no-invalid-names` HOT 1
- `no-loose-assertions` doesn't handle globals properly
- `no-loose-assertions` could have suggestions added
- Feature Request: `require-expect` allow-list HOT 3
- Please, enable eslint@8 support HOT 4
- `no-loose-assertions` and many other rules don't work in arrow functions HOT 1
- `no-assert-equal` does not work with typescript `this` HOT 1
- Explore release-it as a way to automate release process further HOT 4
- V8 Planned Changes HOT 16
- False positive for `no-hooks-from-ancestor-modules` HOT 1
- Missing github releases HOT 2
- 7.2.0 - qunit/require-expect not correctly handling arrow function
- Requesting a 7.3.2 release HOT 6
- Add TypeScript type-checking to all rules HOT 2
- `qunit/require-expect` reports some warnings that it should not HOT 8
- Delete the outdated `next` tag from NPM HOT 2
- no-hooks-from-ancestor-modules does not catch when arrow function is used HOT 1
- V9 Planned Changes HOT 6
- Consider removing require-expect from the recommended ruleset HOT 10
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from eslint-plugin-qunit.