Preserve --include/--exclude order when using mount:download about legacy-cli HOT 6 CLOSED

If --include is used without an --exclude, always append '--exclude=*' as it will not work otherwise

Does it depend what you expect --include to do? Both your examples ended up syncing the .txt files that were requested.

man rsync says:

  --include=PATTERN        don't exclude files matching PATTERN

Exclude before include makes sense

from legacy-cli.

Does it depend what you expect --include to do? Both your examples ended up syncing the .txt files that were requested.

Yes, that's intended for rsync, but our help message mentions:

      --include=INCLUDE              File(s) to include in the download (pattern) (multiple values allowed)

Personally, I would expect --include to only include the given pattern.

from legacy-cli.

2. Include --exclude argument before --include

It looks like we already do this part:

from legacy-cli.

Yes, you're correct. I messed up the order - it seems like the correct order is the opposite one (include before exclude).

PLATFORMSH_CLI_DEBUG=1 platform mount:download -m .cache --target .cache --yes --include='*.txt' --exclude='*'
...
# Running command: 'rsync' '--archive' '--compress' '--human-readable' '-vv' 'XXX:.cache/' '.cache' '--exclude=*' '--include=*.txt'
...
[sender] hiding file one.txt because of pattern *
[sender] hiding file two.pdf because of pattern *

What we'd like to do is:

'rsync' '--archive' '--compress' '--human-readable' '-vv' 'XXX:.cache/' '.cache' '--include=*.txt' '--exclude=*'
...
[sender] showing file one.txt because of pattern *.txt
[sender] hiding file two.pdf because of pattern *

from legacy-cli.

OK reading deeper in the man page:

   The order of the rules is important because the first rule that matches is the one that takes effect.  Thus, if an early rule excludes a file, no include rule that comes after
   it can have any effect. This means that you must place any include overrides somewhere prior to the exclude that it is intended to limit.

from legacy-cli.

I've updated the PR #1304 to address that

from legacy-cli.