Comments (13)
Dmytro, I'd like to start with this one! I might submit a PR early and ask for help/feedback. I haven't really done any Atom development yet, so this will be a fun/interesting way to jump in!
Expect a starting PR from me within the next two weeks.
from platformio-atom-ide-terminal.
Considering #33 and #20 I'd say that there is a demand for this. So I'd leave the issue open and hope that someone else will have a time to implement this at least for built-in themes.
from platformio-atom-ide-terminal.
Are there some updates regarding this issue?
from platformio-atom-ide-terminal.
I don't know if this is enough for most of you guys, but for me, adding this to styles.less this did the trick:
@import` "syntax-variables";
.platformio-ide-terminal .xterm {
background-color: @syntax-background-color ;
}
I know that this is not the issue for most of you, but I only use 2 themes (light/dark), so this was enough for me, the catch is: finding the right colors to look nice across both themes (and in my case, windows and linux).
from platformio-atom-ide-terminal.
+1 would be nice if ansiColors are automatically set based on theme. meantime for one-dark
i add this to my ~/.atom/config.cson
;
"platformio-ide-terminal":
ansiColors:
normal:
black: "#282c34"
blue: "#61afef"
cyan: "#56b6c2"
green: "#98c379"
magenta: "#c678dd"
red: "#e06c75"
white: "#abb2bf"
yellow: "#e5c07b"
zBright:
brightBlack: "#454c59"
brightBlue: "#69bbff"
brightCyan: "#66d9e8"
brightGreen: "#b5e890"
brightMagenta: "#e48aff"
brightRed: "#ff7a85"
brightWhite: "#cfd7e6"
brightYellow: "#ffd68a"
core: {}
iconColors:
blue: "#61afef"
cyan: "#56b6c2"
green: "#98c379"
magenta: "#c678dd"
orange: "#d19965"
pink: "#c578dd"
purple: "#d682f0"
red: "#df6b75"
yellow: "#e2c08d"
style:
fontFamily: "Droid Sans Mono for Powerline"
theme: "one-dark"
toggles:
selectToCopy: false
from platformio-atom-ide-terminal.
A PR would be much appreciated!
Terminal colors are set here:
platformio-atom-ide-terminal/lib/view.coffee
Lines 300 to 321 in 9ac54fb
This defines standard ANSI colors You'll have to define all 16 colors for each theme manually (I don't think it's possible to extract the needed colors from theme directly, so manual work is necessary here). You'll also want to define the terminal background color at
@terminal.colors[256]
(source). I did play with background color recently myself, so I can give you a hint, if you need one.
You can use the atom.themes.onDidChangeActiveThemes()
method to get notified when the active themes are changed and then atom.themes.getActiveThemes()
to retrieve a list of active themes. Now you know the names of active themes, so you can set configure the terminal colors accordingly.
A list of built-in themes can be found right here. It's probably better to start with support of the built-in themes.
Let me know if you still want to work on this issue or need any help.
from platformio-atom-ide-terminal.
Hey guys, quick update: two weeks turned into TBD. I've got some other side-project stuff I'm working on. I'd like to start this project soon but I don't have a timeline as of right now, but I'll let you know!
from platformio-atom-ide-terminal.
Ok guys, I looked into it and it will be fruitless to try and match the terminal colors with the syntax theme since there is no proper convention for labeling colors (e.g. red, blue, yellow) in the less files.
I think it would be best to just close this issue.
from platformio-atom-ide-terminal.
My thought is maybe having a dropdown option for preset themes (matching default themes)?
Or I guess you could write custom functions that convert some of the default themes into the terminal manually?
For me, it only took 30 seconds using the eyedropper to change the colors to my color syntax of choice. But I can see how it would be helpful to have some better default options 😄
from platformio-atom-ide-terminal.
- 💯
from platformio-atom-ide-terminal.
Thx @danielbibit , I added another entry for the text-color:
@import "syntax-variables";
.platformio-ide-terminal .xterm {
background-color: @syntax-background-color ;
color: @syntax-text-color;
}
from platformio-atom-ide-terminal.
How can I add a hexcode colour as the theme?
from platformio-atom-ide-terminal.
should be handled by 27a4c04
from platformio-atom-ide-terminal.
Related Issues (20)
- not able to download terminal HOT 1
- can't install platforio-ide terminal in my atom, (windows), solve my problem HOT 1
- issue
- Issue inserting multi-line code from editor HOT 1
- 1
- administrator
- akblyt63
- HTMLDocument.registerElement is deprecated. HOT 1
- Platformio-Ide-Terminal not showing in my atom-packages and its not uninstalling and I can't reinstall it HOT 1
- can't installing
- Platformio-ide-terminal issue HOT 1
- Cannot find module
- Error
- Erro ao instalar o platiformio -ide- terminal
- Platformio-ide-terminal error install
- Platformio-ide-terminal is not installing
- terminal not downloading
- terminal - impossible to download
- platformio-ide-terminal
- unable to install platformio-atom-ide-terminal HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from platformio-atom-ide-terminal.