A minor incompatibility with very old Flask versions has crept in about flask-rebar HOT 3 CLOSED

First, a note on why #73 might've failed:
It might have something to do with this: https://github.com/plangrid/flask-rebar/blob/master/flask_rebar/rebar.py#L59
We might just need to tweak that a bit to be 301 or 308.

Second, regarding the bigger question: Do we need to support Flask 0.10?

Here's what we know:

• Maintaining support for Flask 0.10 is a pain
• Library support is part of our packages contract to consumers
• Removing library support is a breaking change
• Breaking changes require bumping the major version of Flask-Rebar

We could sneak the removal of this support without bumping the major version if we were confident that no one is using Flask 0.10. However, since this is open source, there's no good way to know that.

So, I think that leaves us with two options:
(1) Deal with the pain for now and make the change work with Flask 0.10
(2) Remove support for Flask 0.10 and bump the major version of Flask-Rebar

My gut says maintaining support hasn't gotten painful enough yet and we should go with option (1).

Maybe it will get painful enough, and we can remove it. Or maybe we'll have another reason to release a major version (Open API 3.0?), at which point we could remove support.

from flask-rebar.

So, yeah.. you nailed it. The issue was actually potentially a bit more than just "breaking our unit tests" so I've adjusted that pre-0.11 bit to now treat 308 same as 301 and all seems right with the world again. Thanks again!

from flask-rebar.

Thanks, Barak - appreciate the perspective, and I hadn't noticed that bit you pointed to. Will check that out!

from flask-rebar.