Code Monkey home page Code Monkey logo

Comments (9)

AuroraLS3 avatar AuroraLS3 commented on June 12, 2024 1

Thanks for the insight in how it might need to wait after login, I didn't know that ws the case so it should make it easier to fix it

from plan.

AuroraLS3 avatar AuroraLS3 commented on June 12, 2024 1

Please test this build https://github.com/plan-player-analytics/Plan/actions/runs/8213295818

It adds a 1 second wait before asking for the premium status.

from plan.

AuroraLS3 avatar AuroraLS3 commented on June 12, 2024 1

I'll reopen this in case it's FastAPI clearing the premium status on player leave and Plan recording that afterwards

from plan.

Athar42 avatar Athar42 commented on June 12, 2024 1

Just a little reply after the latest update : This new change seems to do the trick, I didn't revert, on my short testing, to "Unknown" status.

As usual, great job, thanks for that nice plugin !

from plan.

Athar42 avatar Athar42 commented on June 12, 2024

It's a simple guess, unsure if that's the cause of the behavior I witness here, but that's the best I came accross :D

If any tests needed (testing a new build, or anything to track this bug), feel free to ask me :)

from plan.

Athar42 avatar Athar42 commented on June 12, 2024

Little update, seems to look better, just a little one still fail so far.

So, most of my servers get correctly from :
image

to

image

But I still have a couple that didn't update correctly on the first login attempt like the lobby server.
Going back and forth from one server to another get the correct status.

So, seems fixed, but a greater delay might be needed :) (like 2, 3 or 5secs).

From the server page (other players didn't reconnect yet), so at least now, it can get the correct value, but I think the delay isn't enough right now :)
image

Edit: I think there is a typo on the comment :P "the API doesn't provide a Future." (not "Feature" ? )

from plan.

AuroraLS3 avatar AuroraLS3 commented on June 12, 2024

A Future is a concept in Java where another thread than calling thread is performing a task - in this case FastAPI is getting the premium status.

If the FastAPI api returned a future I would be able to "wait until this is done" rather than add an arbitrary amount of seconds to wait

from plan.

Athar42 avatar Athar42 commented on June 12, 2024

A Future is a concept in Java where another thread than calling thread is performing a task - in this case FastAPI is getting the premium status.

If the FastAPI api returned a future I would be able to "wait until this is done" rather than add an arbitrary amount of seconds to wait

Thanks for this info, I didn't knew it :)

I'll keep an eye here for any needed tests :)

from plan.

Athar42 avatar Athar42 commented on June 12, 2024

From the tests I made so far, it might be cleared on reconnection.

I think of that because when I join a server where I was previously set as "Premium", I get back to "Unknown" randomly.
But when I got set to "Premium" then go to another server, I still keep the "Premium" statut in PLAN.

If more tests needed, feel free to ask :)

from plan.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.