Comments (9)
Thanks for the insight in how it might need to wait after login, I didn't know that ws the case so it should make it easier to fix it
from plan.
Please test this build https://github.com/plan-player-analytics/Plan/actions/runs/8213295818
It adds a 1 second wait before asking for the premium status.
from plan.
I'll reopen this in case it's FastAPI clearing the premium status on player leave and Plan recording that afterwards
from plan.
Just a little reply after the latest update : This new change seems to do the trick, I didn't revert, on my short testing, to "Unknown" status.
As usual, great job, thanks for that nice plugin !
from plan.
It's a simple guess, unsure if that's the cause of the behavior I witness here, but that's the best I came accross :D
If any tests needed (testing a new build, or anything to track this bug), feel free to ask me :)
from plan.
Little update, seems to look better, just a little one still fail so far.
So, most of my servers get correctly from :
to
But I still have a couple that didn't update correctly on the first login attempt like the lobby server.
Going back and forth from one server to another get the correct status.
So, seems fixed, but a greater delay might be needed :) (like 2, 3 or 5secs).
From the server page (other players didn't reconnect yet), so at least now, it can get the correct value, but I think the delay isn't enough right now :)
Edit: I think there is a typo on the comment :P "the API doesn't provide a Future." (not "Feature" ? )
from plan.
A Future is a concept in Java where another thread than calling thread is performing a task - in this case FastAPI is getting the premium status.
If the FastAPI api returned a future I would be able to "wait until this is done" rather than add an arbitrary amount of seconds to wait
from plan.
A Future is a concept in Java where another thread than calling thread is performing a task - in this case FastAPI is getting the premium status.
If the FastAPI api returned a future I would be able to "wait until this is done" rather than add an arbitrary amount of seconds to wait
Thanks for this info, I didn't knew it :)
I'll keep an eye here for any needed tests :)
from plan.
From the tests I made so far, it might be cleared on reconnection.
I think of that because when I join a server where I was previously set as "Premium", I get back to "Unknown" randomly.
But when I got set to "Premium" then go to another server, I still keep the "Premium" statut in PLAN.
If more tests needed, feel free to ask :)
from plan.
Related Issues (20)
- Player Join Addresses showing garbled data
- Automate CurseForge game version support tags
- Duplicate world names HOT 3
- Problem PLAN HOT 1
- Verify source of downloaded geodb
- Placeholderapi HOT 1
- discord login [Oauth2 support] HOT 1
- Errors in console HOT 1
- Regular players, new players, unique players - statistic for every month
- Restructure the HTTPS setup tutorial
- Mixin conflict with CC: Restiched HOT 6
- Chinese translation error HOT 3
- Add Skript support HOT 3
- Join address data gathering settings HOT 1
- Placeholders do not update HOT 3
- Export a log to text? HOT 1
- Add Servers Uptime Placeholders HOT 1
- Easier login system HOT 11
- SQL error in console HOT 6
- Bug since recent update : Illegal pattern character 'A' HOT 12
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from plan.