Please replace #define swap() about adafruit_mfgfx_ide HOT 6 CLOSED

@ScruffR, the question is why does the swap macro cause issues? It would be very simple to wrap the definition like this:

#ifndef swap
#define swap(a, b) { int16_t t = a; a = b; b = t; }
#endif

Could you this that a shot?

from adafruit_mfgfx_ide.

The problem seems to be that once swap is defined as macro, the swap function in std::vector and other std:: containers is hidden by the macro.

On the other hand, if I flip the includes round, any call to vector::swap results in an error.
So the only way around this is to rename the swap macro or limit its lifetime to the GFX library only.

BTW, the same issue is presend with the Adafruit_GFX lib.

from adafruit_mfgfx_ide.

Then perhaps the best solution is to change swap to swapBytes or something similar.

from adafruit_mfgfx_ide.

Yup, that'd help

from adafruit_mfgfx_ide.

Do you want to do a PR? Otherwise, I'll get to it this weekend.

from adafruit_mfgfx_ide.

I'll see how my home schedule looks like this weekend ;-)

from adafruit_mfgfx_ide.