[Wallet] Segmentation fault on masternode with --disablewallet about pivx HOT 6 CLOSED

ahh yeah, that is a separate issue, but will need to be done regardless

from pivx.

After some further review, I think more time will be needed to formulate a proper fix for this. Your PR #159 is a fix that can be applied locally to circumvent the error, but the larger picture is that many aspects of the software are expecting the wallet to be enabled and don't have the proper protection around them.

from pivx.

Fair enough. I'd still really like to see the -staking option added to init.cpp::HelpMessage(), especially since it's enabled by default.

from pivx.

Might be a good idea to add/change the parameter interaction during initialization to disable staking if the wallet is also disabled at runtime (compile-time no-wallet builds are currently not working, but consideration should also be made to assume such functionality will be restored)

Examples of the type of parameter interaction I'm talking about can be seen when processing the -connect parameter, which if set will disable -dnsseed and -listen

If you feel up to the task, just post here and/or open a new PR, otherwise I will probably be able to work on it next week (this goes for anyone else that may have interest in addressing the issue too)

from pivx.

from pivx.

Closing now that #180 has been merged

from pivx.