Missing StatusOK 200 about brokerapi HOT 5 CLOSED

We have created an issue in Pivotal Tracker to manage this:

https://www.pivotaltracker.com/story/show/167969937

The labels on this github issue will be updated when the story is started.

from brokerapi.

Hey @mrgunior!

Thanks for writing. We write brokerapi in conjunction with our on-demand service broker, which interacts with CF. Interestingly and for some reason no one currently on the team knows, the on-demand broker doesn't follow spec, and our broker returns an [instance exists error](Use github.com/pivotal-cf/brokerapi/domain) error, which is handled in the broker api in the [error checking](Use github.com/pivotal-cf/brokerapi/domain).

In order to return the StatusOK 200, we thought of a couple of possibilities.

The provisionResponse could be extended to include a new property like InstanceAlreadyExists, and that could be checked after the broker returns. If it's true, return 200.

Or before the broker Provision gets called, there could be a call to the OSBAPI GetInstance endpoint. If the incoming ProvisionDetails match details from the result of GetInstance, return 200 and never ask the broker to provision.

Were you thinking of other options?

Also our team would need time to make the change as we have other things active at the moment. Is this something you'd want to PR?

Thanks
Winna

from brokerapi.

Get instance won't work, since according to the specs provision should be the one to do these checks. Get instance also doesn't really help, since not all parameters are set by the user from upfront. There needs to be a thorough check between the local and the remote instance and a correct code response should be returned.

from brokerapi.

Thanks for getting back to us @mrgunior. It sounds like you have an approach in mind. Do you have time/capacity to PR the work and tests for this?

from brokerapi.

Merged this functionality in #77

from brokerapi.