Comments (4)
We have created an issue in Pivotal Tracker to manage this. Unfortunately, the Pivotal Tracker project is private so you may be unable to view the contents of the story.
The labels on this github issue will be updated when the story is started.
from brokerapi.
Thanks for raising the @joek.
The team are going to discuss this soon and we will get back to you with an answer!
from brokerapi.
Hey @joek Thanks for submitting the PR.
You covered three changes in #35. Would you mind submitting three separate PRs for each? It's just a bit cleaner.
- Regarding the
RawParameters
inconsistency, we agree that it would be best if theBindDetails/UpdateDetails
had aRawParameters
field with typejson.RawMessage
. - With regards to the new errors you introduced in #35, what's the point of having them if the broker api code doesn't check for them (i.e. https://github.com/pivotal-cf/brokerapi/blob/master/api.go#L102 for
update
and https://github.com/pivotal-cf/brokerapi/blob/master/api.go#L255 forbind
)? What do you think these errors should translate to in HTTP codes? It does not seem that the broker spec accounts for them at the moment. - Your changes regarding
LastOperationState
inLastOperationResponse
look good.
And yes, please run (and fix) the tests. 😻
from brokerapi.
@Samze thanks for your response. I will send pull requests as soon as I cleaned up my messy changes and added testing ;-)
from brokerapi.
Related Issues (20)
- Binding struct is missing support for Endpoint? HOT 4
- Audit log by the APIHandler type HOT 3
- Missing metadata field in ProvisionedServiceSpec HOT 4
- Missing allow_context_updates field HOT 7
- Unversioned handlers shouldn't not use versioned domain/apiresponses HOT 2
- Use of authentication methods other than Basic Auth HOT 6
- v8 backwards compatiblity HOT 7
- Is the FailureResponse status code used? HOT 4
- test issgu HOT 1
- Incorrect type for metadata fields in Get/Provision/Deprovision responses HOT 3
- Broker does not accept url-encoded forward slash in instance_id HOT 6
- Ability to implement custom ServicePlanCost? HOT 1
- Feature request: Simple way to add prometheus exporter HOT 3
- Support for Binding rotation HOT 3
- Requirement to expose additional API endpoints HOT 3
- Setting CF labels not supported? HOT 4
- Use chi.Router interface for AttachRoutes method HOT 3
- for v11: NewFailureResponse() should return error not *apiresponses.FailureResponse HOT 3
- Replace lager.Logger with log/slog.Logger HOT 4
- Possibility to register a custom middle ware HOT 5
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from brokerapi.