Opcode checking needed about python-websocket-server HOT 2 CLOSED

And not sure if you really meant to implement the opcode checking in message_received(), a callback provided by the developer or read_next_message(), where you already check the CLOSE_CONN.

If we let the developer handle this, the only thing we have to do is to add the OPCODE to the arguments given to message_received(). This is very straightforward to implement but in this case, we won't be able to issue a warning on unknown OPCODE (it will be the developer's reponsibility also) without double-checking.

Is this an issue in your opinion @Pithikos ?

from python-websocket-server.

Oops, my mistake. I did indeed meant read_next_message(). What makes sense to me is that in read_next_message() will do all the evaluation etc. of a received message. Then depending on what message was received a different action has to be made (print warning, read payload, send pong, etc.). Ofcourse the best way would be if every action it's just a separate method just for the sake of modularity.

from python-websocket-server.