Threaded serve_forever about python-websocket-server HOT 6 CLOSED

Not quite sure what I did but will put it here if it helps anything...

Was looking at different way to do threading in python and ran across this threading link.

I went into the websocket_server.py file and modified

def run_forever(self):
        try:
            logger.info("Listening on port %d for clients.." % self.port)
            self.serve_forever()

to this

def run_forever(self):
        try:
            logger.info("Listening on port %d for clients.." % self.port)
            # self.serve_forever()
            _serve = self.serve_forever
            # Start a thread with the server -- that thread will then start one
            # more thread for each request
            server_thread = threading.Thread(target=_serve)
            # Exit the server thread when the main thread terminates
            server_thread.daemon = True
            server_thread.start()

Not sure why or how...but now my app appears to start the socket server...continue along peacefully and connect to my browser client. Best accidental discovery I have made today lol

Is this something that could be useful for others?

from python-websocket-server.

You don't have to do that. You should be able to run server_forever as a separate thread, similarly to how you did it.

I think the issue you first experienced was that you were passing threading.Thread(target=server.run_forever()) instead of (the correct) threading.Thread(target=server.run_forever). Notice that in the latter you are passing the function while in the first you are actually running the function.

from python-websocket-server.

It appears that the Ctrl+C trick only works once the client already connects to the socket server

So this works

• start socket server
• connect browser client
• Ctrl+C python code
• execute remaining while loop

This does NOT work

• start socket server
• Ctrl + C
• connect browser client (fails)
• remaining loop runs

from python-websocket-server.

@afreeland Dude you literally probably saved me hours with this thanks so much. Maybe you make pull request for it?

from python-websocket-server.

@murphy214 Glad I could help =)

from python-websocket-server.

Original solution may have been overthinking it, but I had been trying something very similar with multiprocessing and running into pickle/cross-process issues with the server object. Didn't think to try threading instead until I saw this conversation. Kudos to @afreeland for the inadvertent solution.

And lest it be misinterpreted, many thanks to @Pithikos for the fantastic Pythonic WebSockets solution. Minimal dependencies, beautifully clean API, robust use-case support. Invaluable.

from python-websocket-server.