Code Monkey home page Code Monkey logo

Comments (6)

Tornth avatar Tornth commented on May 22, 2024

The very first image of mine also disappear. Can you suggest the workaroumd?

from reel.

Witti avatar Witti commented on May 22, 2024

After all images are loaded the first image src is replaced with this string "gif;base64,R0lGODlhCAAIAIAAAAAAAAAAACH5BAEAAAAALAAAAAAIAAgAAAIHhI+py+1dAAA7" so the first image can't be displayed.

Workaround:
Remove line no 322 ("t.attr({ src: transparent }).trigger('loaded');")

from reel.

DaveGorski avatar DaveGorski commented on May 22, 2024

removing line 322 breaks the plugin for sprite based reels.
try

if(opt.images.length == 0){
    t.attr({ src: transparent }).trigger('loaded');
}

this will work in both cases

from reel.

pisi avatar pisi commented on May 22, 2024

Dave! Guys!

I've immediatelly tested out your suggested method and it indeed works. Not for 100% because the loaded event trigger is an important one and must be triggered. But pretty pretty close!

I've adapted your solution in a branch gorski-method and that works just perfect!

Then, however, I've rooted down the stink bit deeper. I realized the reason was that the initial fractionChange event for default initial frame was being dropped as not-changed. Modified dropping condition is another solution for this fix and this one will probably make it into patch release 1.1.1.

Till then the cleanest solution is condition modification in the zero-fraction-fix branch.

Both branches include a test case.

Thank you very much, guys for practically solving this instead of me. Very much appreciated!

from reel.

Archivist-zz avatar Archivist-zz commented on May 22, 2024

Oh, I apologize, I made a new post about this issue, but didn't see this here.

I hope 1.1.1 can be released soon!

from reel.

pisi avatar pisi commented on May 22, 2024

Hey!

I just released a patch version 1.1.1, which has a built-in cure for this issue along with test case assuring it won't re-emerge.

from reel.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.