File with CRLF + markdown renderered incorrectly about gostatic HOT 13 CLOSED

Oh, I think that's because config splits on ----\n, and CRLF has ----\r\n instead. Maybe we should just split by regexp there? Like, ----\r?\n.

from gostatic.

Indeed, see source. I guess the safest version would be to use a Scanner to read line by line until the ---- has been found. See the example from the bufio package.

from gostatic.

I was also thinking - maybe try to split by \n----\n, and if it didn't work (there is only one part), then try to split by \r\n----\r\n.

Or even better! Choose splitter based on whenever there is \r contained in the file or not and if somebody mixes various line endings, that's their problems. :)

from gostatic.

Well that doesn't sound too user friendly... :P I'll check if I can whip something up with a reader or whatever. That way it doesn't really matter if you use \r\n, or \n, or \r or whatever the editor/user makes of it.

from gostatic.

Hi, I got the notice and I'll test that later (not sure when, though, I'm very busy at the moment).
I've read the comments and I'm pretty sure some systems use \r as the EOL marker so shouldn't we (i.e. you ;) ) cover all combinations (CRLF, CR and LF) ? What do you think?
Aren't there native Go functions that deal with that ?

from gostatic.

There was some merit in your comment. I remember MacOS used CR exlusively, but after some research, this only seem to apply to version prior MacOS X or whatever. Check out this list, and here.

AFAIK, gostatic (or any other Go program) doesn't compile on the other systems mentioned (Acorn BBC, QNX, RISC ...), so I suppose Windows CRLF and the Nix-es + Macs LF remain to support.

from gostatic.

At least we've learnt something in the process. ;)
I tried both 32 and 64 bit editions of the latest version and neither worked (both on Win8 x64).

from gostatic.

Did you use a binary that was built from source? If you didn't, that explains why neither worked :) The fix has been introduced in commit 311e9e5.

from gostatic.

I went to the download page without a second look. ^^
Is there a binary with the fix lying around?

from gostatic.

I downloaded the tools and the source code but I haven't used a Makefile in a while and I'm running Windows anyway. I don't have the time to figure out how to build it at the moment, is there a "how to build GoStatic on MS Windows(R) for dummies" doc, by any chance?

from gostatic.

Let's do it other way around: I'll just check a bit later myself and will do a new release if it works. :)

from gostatic.

Ok, I've checked and it works, so you can download 2.4, which will work. :)

from gostatic.

It does indeed. Thanks. :)

from gostatic.