connections to multiple parents about drakon-renderer HOT 6 CLOSED

OK, this is something I've been preparing myself for a while now. This change represents the hardest code in the application so far, so it will probably take a while to get it right.

Below is a sample problematic situation we can get into today:

action 3 is a child of both:

• question 2
• question 3

which results in some problems:

• it and its children should not be rendered twice
• each icon should only be rendered once
• there can be multiple connections from a child to its parents (we already have multiple connections from a parent to many children)

from drakon-renderer.

A reasonable next step would be to flesh out the troubleshooting mode with:

• replace max width with an actually useful information like origin coordinates
• a bool signifying whether an icon has already been rendered

from drakon-renderer.

OK, origin coordinates for troubleshooting done:

from drakon-renderer.

I added a comment to the TODO function a while ago which stated:

-- we should have a bit of new logic here:
-- if, while iterating through the list of icons, you come across an icon
-- that is already in the returned collection of triples (rendering order, max width, (coordinates, diagram))
-- take that found end icon from the returned collection and mappend a connection to the new parent node to it

Now that I:

• started working on adding the "already rendered" troubleshooting indicator
• took the time to read the code very carefully

I realised that it would be impossible. That collection of triples I mentioned only contains nodes that are assigned to the current node as children - it doesn't contain all graph nodes. I will have to rethink how we keep track of already rendered nodes...

from drakon-renderer.

So at this stage I'm convinced that while rendering individual steps, we shouldn't also connect to their parents as, if we spot a new parent while iterating through the list of icons, we would have to retrace back to that already rendered icon and then connect it to the newly found parent. I feel it's unnecessarily complicated.

Additionally, I realised that even if I remove the functionality that connects newly rendered icons with their parents, the positioning will still be wrong (it already is wrong). Icons should not be rendered if they are already rendered.

I fear I will have to rethink this general group of functions:

[Icon] -> [Diagram]

from drakon-renderer.

Transferring the issue here to assign it to a roadmap project: #22

from drakon-renderer.