Comments (2)
Great find @matejsp, I suspect the way to optimize this is to refactor the hashing client to use a similar pattern to python-memcached's model.
We haven't hit this issue ourselves as use mcrouter.
from pymemcache.
Since I referenced this issue in Django, I would like to share some additional benchmarks that I made using pymemcache and python-memcached inside Django.
We are using memcached (ElastiCache) that has a round trip from each server on average 1 ms.
In our case we use 4 memcached server and when we call get_many based on hash algorithm it splits the load between all 4 servers and calls on each server get_many. Each call takes 1 ms so in total we observed total time of 4 ms (can also be 1ms, 2ms, 3ms, 4ms depending on hash key distribution and how many servers you hit with get_many).
In python-memcached when calling 4 servers in a loop the logic is optimized in a way that it first it sends to all 4 server and only then in receives the response from each of them taking 1 ms (basically waits for the slowest server) in total to complete get_many call.
I checked the code and from what I see _fetch_cmd/_store_cmd should be splited into sending and receiving logic and somehow brought up to hash client taking connection pooling into account. You would need to get 4 servers from pool, call send on each and then wait for receive for all servers.
from pymemcache.
Related Issues (20)
- KeyError caused by wrong key type. HOT 2
- Feature request: Support for Get and Touch HOT 1
- Usage on arm servers? Invalid magic error HOT 1
- Feature request: Pass hashed server value to get/set/delete functions (for example get_many to one hashed server) HOT 1
- Add an existing key, expects to fail but returns True HOT 1
- Intermittent MemcacheUnknownCommandError for "lru_crawler metadump all" HOT 3
- MockMemcacheClient return string as bytes HOT 2
- How to properly set the `timeout` and `connect_timeout` values? HOT 1
- Different signature/behaviour of incr, decr for Hash and Base.
- Broken tests on i686-linux
- pip install pymemcache empty __pycache__ folder under pymemcache
- Add support for blocking pools HOT 2
- Delete key from every node HOT 9
- Would it be feasible to provide asyncio compatible client? HOT 1
- Feature Request [Elasticache-Auto-Discovery] HOT 3
- Python hangs when calling flush_all and doing add or set operation with multiprocess. HOT 2
- Can't pickle local object 'monta_cardapio_por_secao.<locals>.<lambda>' HOT 2
- AttributeError: 'HashClient' object has no attribute 'stats' HOT 1
- pymemcache.exceptions.MemcacheUnknownCommandError: b'get' when hitting maximum number of connections HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from pymemcache.