Code Monkey home page Code Monkey logo

Comments (5)

fishcakez avatar fishcakez commented on July 17, 2024

A new exometer_core has been released with required changes, and published on hex as v1.5.2. However it's setup dependency fails to build.

from elixometer.

surik avatar surik commented on July 17, 2024

The reason to fail build looks like Makefile missing in setup package, see uwiger/setup#41

from elixometer.

fishcakez avatar fishcakez commented on July 17, 2024

master now supports exometer_core 1.4 and 1.5 but:

We override exometer's lager dependency for OTP 19+ compatibility, and we can't build a hex.pm package until we remove the override.

Unfortunately to support 1.5 we needed to override another dependency, setup.

To resolve the setup override we need to handle a compiling issue when using the current hex package at uwiger/setup#44. Once this is resolved it will mean a new setup version, likely 1.8.5. Unfortunately exometer_core pins exact version 1.8.4, so we would also need a new release of exometer_core pointing to the new setup version as well. This would move our version requirement to "~> 1.4.0 or ~> 1.5.3 or ~> 1.6" as 1.4.0 pins a different version (1.7.0) of setup.

To resolve the lager override we would either need to drop support for 1.4 (cc @nichochar) or backport the lager fix to an exometer_core 1.4.1. Note that 1.5 introduced a breaking change in Feuerlabs/exometer_core@7a3c1ba and Feuerlabs/exometer_core@9010438. I have not investigated if these changes are likely to hit users or not. This would move our requirement to "~> 1.4.1 or ~> 1.5.3 or ~> 1.6", forcing at least a patch version update on users when they upgrade.

from elixometer.

fishcakez avatar fishcakez commented on July 17, 2024

Requiring exometer_core ~> 1.5.2 or ~> 1.6 would ensure no one hits #77.

from elixometer.

jparise avatar jparise commented on July 17, 2024

Version 1.3.0-RC1 has been released: https://hex.pm/packages/elixometer/1.3.0-rc1

from elixometer.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.