Code Monkey home page Code Monkey logo

Comments (4)

weekface avatar weekface commented on May 27, 2024

Good Catch! Thank you.

Further moreover:

  1. Replace reflect.DeepEqual with apiequality.Semantic.DeepEqual which is supplied by K8s.
    return apiequality.Semantic.DeepEqual(oldSpec, new.Spec), nil
  2. Add unit test to cover this situation

Would you like to resolve this problem?

from tidb-operator.

mathspanda avatar mathspanda commented on May 27, 2024

Sure.

from tidb-operator.

weekface avatar weekface commented on May 27, 2024

Close in favor of #75

from tidb-operator.

weekface avatar weekface commented on May 27, 2024

Thank you for your feedback.

from tidb-operator.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.