Code Monkey home page Code Monkey logo

Comments (5)

csuzhangxc avatar csuzhangxc commented on June 25, 2024

@hongshaoyang did you set the value of paused (pause: ${var.is_backup_paused}) to true or false? some default values may be absent in the manifest.

from tidb-operator.

hongshaoyang avatar hongshaoyang commented on June 25, 2024

@csuzhangxc - it is set to the default, false, that is, scheduled backups are not paused.

some default values may be absent in the manifest.

but that is not expected. this will cause issues with infrastructure-as-code tools like terraform which expect values to not change over time.

from tidb-operator.

csuzhangxc avatar csuzhangxc commented on June 25, 2024

specially, for this pause: false, I tested it on Kubernetes server v1.27.3 and client v1.29.0, I can get it back with -o yaml.

Can you try it on other versions of server and client?

from tidb-operator.

hongshaoyang avatar hongshaoyang commented on June 25, 2024

Our GKE clusters are standardised to be the same version across. So I cannot try it on other versions.

One observation is that after applying the Kube manifest, I also can view the pause: false field immediately with -o yaml. But after a while (after the backup was created) the .spec.pause field became absent.

from tidb-operator.

csuzhangxc avatar csuzhangxc commented on June 25, 2024

but that is not expected. this will cause issues with infrastructure-as-code tools like terraform which expect values to not change over time.

One possible method to resolve it may not set these empty values in IaC tools as K8s/Golang-JSON has the omitempty behavior.

from tidb-operator.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.