+.lo - Linefeeds assumed from failed login about imagebbs HOT 6 CLOSED

I expanded the research on this a little bit. Using an ANSI terminal I connected and attempted to login as a user with no linefeeds. (Can be simulated by a user entering what they "thought" was their ID#, while actually being that of a user with C64 configuration.
The issue becomes apparent after completing the password attempt. (security check)
Further research reveals that this happens when the attempted user is a non-converted 1.2 user, more specifically one who has not had record# 13 of u.config converted from the single digit linefeeds integer (ll) to the 11 digit flag string (uf$).
During the load of user information (im.misc), an UNCONVERTED user still has the left padding on that record. Wonder if that's getting a false null for linefeeds?
Also, since lf% is being set here, does the matching lightbar flag being set? Doesn't look like it, all I see is the menu mode (&,52,44) and more prompt mode (&,52,34) being set on line 60042 (im.misc)

from imagebbs.

The lightbar position would be &,52,17:

We could add that somewhere. Not sure just where at the moment. Not sure about lf% right now. So many variables!

Sounds like we need to add stuff to record 13 in u.config on conversion from 1.2 -> 2.0, then.

from imagebbs.

+.lo: lf=1 happens twice, but never applied to &,52,17, which is called a few times. Then lf is overwritten by im.misc loading stats, of which one is lf.

I'm thinking lf% (or some other temporary variable) should save the user's initial linefeed setting at graphics detection, then restore it after the failed login. I'm working on a pull request to see about the feasibility of this.

from imagebbs.

@ThaDoctor72 , what do you think of this fix?

from imagebbs.

from imagebbs.

Honestly I have not seen a terminal in years that produced "too many" linefeeds, since nobody uses WYSE boxes anymore. I would say have all user accounts updated to 1 for linefeeds, and if someone has issues with it they can turn it off. It would be a vast minority of users who have issues with extra feeds.
Better to have too many than not enough, in my opinion.

from imagebbs.