Comments (9)
Fix released in lektor-minify 1.2.
from lektor-minify.
I can't reproduce this issue, unfortunately. Which version of Lektor are you using? From the traceback I guess this is on Python 2.7.
By the way, this is strange: it seems like the before-build-all
event isn't called before after-build
, and self.seen_artifacts
is defined in the first one.
from lektor-minify.
Oh! Forgot to mention I am using the latest master branch from the repo on Ubuntu 16.04
from lektor-minify.
Also this happens only with lektor serve and not with lektor build. I guess sequence of events must be different in both cases.
from lektor-minify.
Does this also happen with build --watch
?
from lektor-minify.
Will try out tomorrow and let you know.
from lektor-minify.
Could you try with commit 5364de6? I refactored the plugin to avoid using the before-build-all
event (global state is bad anyway), so the issue should be fixed.
I'm still not able to reproduce the issue myself, but looking at the stack trace the only thing I can think about is that the before-build-all
event wasn't fired before after-build
. If the problem is this (and the commit fixes it) I would open an issue in the Lektor project.
from lektor-minify.
Thanks! Your last commit seems to have solved the problem. The plugin works well 👍
from lektor-minify.
Wonderful! I'll make a new release in the next few days.
from lektor-minify.
Related Issues (3)
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from lektor-minify.