Wrong layer and modifier states about prk_firmware HOT 7 CLOSED

@arai-ta Thanks for the report.
Could you use this build https://drive.google.com/file/d/1CuP2CwmZ-xX0W6g_M-IgwUWd9--OovoC/view?usp=sharing
and test again?
I think those problems are no longer reproduced.

from prk_firmware.

I tested with that build.
I confirmed that the bug fixed!
And I found another bug 😅

• (1) press & hold KC_LSFT and...
  • (2) tap KC_A => A 🙆‍♂️
  • (3) tap KC_B => B 🙆‍♂️
  • (4) tap LAYER_C =>C 🙌
  • (5) tap KC_A => A 🙌
  • (6) press & hold LAYER_C and...
    • (7) tap KC_A =>
      • expected: ! (because KC_LSFT and LAYER_C is hold)
      • actual: 1
    • (8) tap KC_B =>
      • expected: " on JIS, @ on US
      • actual: 2
    • (9) release LAYER_C
  • (10) tap KC_A =>
    • expected: A (because LAYER_C is not hold)
    • actual: 1
  • (11) tap KC_C =>
    • expected: C
    • actual: Nothing reported

from prk_firmware.

@arai-ta Thanks, but actually, a bug exists on your end :)

kbd.add_layer :raise, %i(
  ________ KC_1 KC_2 ________
)

The above keymap should have been the following:

kbd.add_layer :raise, %i(
  KC_LSFT KC_1 KC_2 LAYER_C
)

Otherwise, the functionality of LAYER_C and KC_LSFT will be away as soon as the layer changes to the ":raise".

PRK Firmware doesn't have special code: ________.

Then, this is the newest version of the test build: https://drive.google.com/file/d/1CwDaMvLD1zFqhqAddmXi0K5T6ckfdtaq/view?usp=sharing
Please try again!

from prk_firmware.

Thank you for your suggestion!
I tested with the build and :raise layer, then it worked perfectly!

I misunderstood that PRK Firmware have KC_TRNS special keycode (in QMK, https://docs.qmk.fm/#/keycodes_basic?id=special-keys ), but didn't.
Do you have any plans to implement the TC_TRNS keycode?

from prk_firmware.

I don’t have a plan to implement KC_TRANS because I myself don’t need it.
But you can raise a feature request issue. It’s not a difficult implementation, I think.

from prk_firmware.

I wish if PRK Firmware has KC_TRNS and ______ alias keycode, because it’s a feature not only for me but also familiar to many QMK users, I think. Please! 🙏

from prk_firmware.

OK, I close here anyway

from prk_firmware.