Code Monkey home page Code Monkey logo

Comments (3)

kermitas avatar kermitas commented on July 19, 2024

Some minor thougts:

  • when external ScheduledExecutorService was passed - Pi4J should not shutdown it on it's own shutdown (because this resource is managed by somebody, somewhere else).
  • when Pi4J internal ScheduledExecutorService is provided to external world (for example by GpioController.getScheduledExecutorService) is should not allow to be shuted down by anybody else than Pi4J (this can be done by returning ScheduledExecutorService inside wrapper - ScheduledExecutorServiceWrapper - where shutdown() and shutdownNow() throws UnsupportedOperationException)

from pi4j-v1.

savageautomate avatar savageautomate commented on July 19, 2024

Good suggestions and I agree with your points. Need to do some refactoring to address these.

from pi4j-v1.

savageautomate avatar savageautomate commented on July 19, 2024

Added support for this feature in the latest 0.0.5-SNAPSHOT (2013-02-09) build.

There is a new ExecutorServiceFactory implementation that allow users to provide their own executor service factory where you users can create the executors and manage own thread pool. Users can assign their own ExecutorServiceFactory implementation via the GpioController.

See https://github.com/Pi4J/pi4j/tree/develop/pi4j-core/src/main/java/com/pi4j/concurrent for more details.

from pi4j-v1.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.